This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5chdn
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
A8-backport 🕸
Pull request is already reviewed well in another branch.
M4-core ⛓
Core client code / Rust.
M2-config 📂
Chain specifications and node configurations.
labels
Sep 25, 2018
5chdn
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Sep 30, 2018
* ci: reduce gitlab pipelines significantly * ci: build pipeline for PR * ci: remove dead weight * ci: remove github release script * ci: remove forever broken aura tests * ci: add random stuff to the end of the pipes * ci: add wind and mac to the end of the pipe * ci: remove snap artifacts * ci: (re)move dockerfiles * ci: clarify job names * ci: add cargo audit job * ci: make audit script executable * ci: ignore snap and docker files for rust check * ci: simplify audit script * ci: rename misc to optional * ci: add publish script to releaseable branches * ci: more verbose cp command for windows build * ci: fix weird binary checksum logic in push script * ci: fix regex in push script for windows * ci: simplify gitlab caching * docs: align README with ci changes * ci: specify default cargo target dir * ci: print verbose environment * ci: proper naming of scripts * ci: restore docker files * ci: use docker hub file * ci: use cargo home instead of cargo target dir * ci: touch random rust file to trigger real builds * ci: set cargo target dir for audit script * ci: remove temp file * ci: don't export the cargo target dir in the audit script * ci: fix windows unbound variable * docs: fix gitlab badge path * rename deprecated gitlab ci variables https://docs.gitlab.com/ee/ci/variables/#9-0-renaming * ci: fix git compare for nightly builds * test: skip c++ example for all platforms but linux * ci: add random rust file to trigger tests * ci: remove random rust file * disable cpp lib test for mac, win and beta (#9686)
niklasad1
force-pushed
the
a5-stable-207
branch
from
October 2, 2018 10:50
acab2c3
to
035ebdc
Compare
5chdn
added
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
and removed
A0-pleasereview 🤓
Pull request needs code review.
labels
Oct 8, 2018
16 tasks
5chdn
added
the
P2-asap 🌊
No need to stop dead in your tracks, however issue should be addressed as soon as possible.
label
Oct 9, 2018
* ci: force-tag wiki changes * ci: force-tag wiki changes * ci: skip docs job for master and nightly * ci: revert docs job checking for nightly tag * ci: exclude docs job from nightly builds in gitlab script
* `ExecutionsRequest` from light-clients as read-only This changes so all `ExecutionRequests` from light-clients are executed as read-only which the `virtual``flag == true ensures. This boost up the current transaction to always succeed Note, this only affects `eth_estimateGas` and `eth_call` AFAIK. * grumbles(revert renaming) : TransactionProof * grumbles(trace) : remove incorrect trace * grumbles(state/prove_tx) : explicit `virt` Remove the boolean flag to determine that a `state::prove_transaction` whether it should be executed in a virtual context or not. Because of that also rename the function to `state::prove_transction_virtual` to make more clear
* sync: set state to idle after sync is completed * sync: refactor sync reset
5chdn
added
A0-pleasereview 🤓
Pull request needs code review.
and removed
A3-inprogress ⏳
Pull request is in progress. No review needed at this stage.
labels
Oct 9, 2018
* Fix path to parity.h * Fix other paths as well
5chdn
added
P0-dropeverything 🌋
Everyone should address the issue now.
and removed
P2-asap 🌊
No need to stop dead in your tracks, however issue should be addressed as soon as possible.
labels
Oct 10, 2018
* ethcore-io uses newer version of crossbeam && retries failed work steal * ethcore-io non-mio service uses newer crossbeam
andresilva
approved these changes
Oct 10, 2018
ordian
approved these changes
Oct 10, 2018
niklasad1
reviewed
Oct 10, 2018
@@ -0,0 +1,46 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should have #!/usr/env bash
here instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. Need to be fixed in master though
niklasad1
approved these changes
Oct 10, 2018
andresilva
added
A5-grumble 🔥
Pull request has minor issues that must be addressed before merging.
A8-looksgood 🦄
Pull request is reviewed well.
and removed
A0-pleasereview 🤓
Pull request needs code review.
A5-grumble 🔥
Pull request has minor issues that must be addressed before merging.
labels
Oct 10, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A8-backport 🕸
Pull request is already reviewed well in another branch.
A8-looksgood 🦄
Pull request is reviewed well.
M2-config 📂
Chain specifications and node configurations.
M4-core ⛓
Core client code / Rust.
P0-dropeverything 🌋
Everyone should address the issue now.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ancient blocks sync (Fix ancient blocks sync #9531)- too hairy to backportread_only executions
only read-only (fix (light/provider) : Makeread_only executions
read-only #9591)shutdown devp2p connections (shutdown devp2p connections #9711)- too late