OPENEUROPA-3295: Create the video iframe media type #106
Conversation
| * @MediaSource( | ||
| * id = "oe_media_iframe", | ||
| * label = @Translation("Iframe"), | ||
| * description = @Translation("Use iframes as source for medias."), |
There was a problem hiding this comment.
Use iframes as source for media entities.
| * {@inheritdoc} | ||
| */ | ||
| public function getMetadataAttributes() { | ||
| return []; |
There was a problem hiding this comment.
Why are we bypassing all the meta attributes? Like the parent provides for the default_name attribute
There was a problem hiding this comment.
The getMetadataAttributes() method is not implemented in the parent class, while the getMetadata() is. We don't support any attribute for now, so we agreed to leave the implementation empty.
| * @FieldFormatter( | ||
| * id = "oe_media_iframe", | ||
| * label = @Translation("Media iframe"), | ||
| * description = @Translation("Renders the iframe for medias with iframe sources."), |
| return TRUE; | ||
| } | ||
|
|
||
| return parent::isApplicable($field_definition); |
There was a problem hiding this comment.
Well, not exactly. The parent returns TRUE so that means that if it's a media but with another source, we also return true. We should return false.
There was a problem hiding this comment.
Opsie! I change it back to a return $media_type &&... like it was.
tests/Behat/FeatureContext.php
Outdated
| $field = $this->getSession()->getPage()->find('named', ['select', $select]); | ||
|
|
||
| if (empty($field)) { | ||
| throw new \Exception("Select field '{$select}' not found."); |
There was a problem hiding this comment.
Because I ©️ 🍝 from EWPP ihih!
tests/features/video-iframe.feature
Outdated
| Feature: Video iframe media. | ||
| In order to show remote videos | ||
| As a site editor | ||
| I want to be able to create medias with iframe as source. |
| Given I am logged in as a user with the "create oe_media_demo content, create video_iframe media" permissions | ||
| When I go to "the Video iframe creation page" | ||
| Then I should see the heading "Add Video iframe" | ||
| And the available options in the "Ratio" select should be: |
There was a problem hiding this comment.
Should we assert this field is properly stored?
There was a problem hiding this comment.
Test will be updated at a later stage.
No description provided.