EWPP-82: Allow to configure a text format for the video iframe source. #117

sergepavle · 2020-07-15T17:11:54Z

OPENEUROPA-[Insert ticket number here]

Description

[Insert description here]

Change log

Added:
Changed:
Deprecated:
Removed:
Fixed:
Security:

Commands

[Insert commands here]

modules/oe_media_iframe/src/Plugin/Field/FieldFormatter/MediaIframeFormatter.php

modules/oe_media_iframe/src/Plugin/Field/FieldWidget/MediaIframeWidget.php

modules/oe_media_iframe/src/Plugin/Field/FieldFormatter/MediaIframeFormatter.php

modules/oe_media_iframe/src/Plugin/media/Source/Iframe.php

modules/oe_media_iframe/tests/src/Functional/MediaIframeFormatTest.php

modules/oe_media_iframe/config/install/filter.format.oe_media_iframe.yml

modules/oe_media_iframe/tests/src/Functional/MediaIframeFormatTest.php

modules/oe_media_iframe/src/Plugin/Field/FieldWidget/MediaIframeWidget.php

modules/oe_media_iframe/tests/src/Functional/MediaIframeFormatTest.php

modules/oe_media_iframe/src/Plugin/Field/FieldFormatter/MediaIframeFormatter.php

modules/oe_media_iframe/oe_media_iframe.post_update.php

modules/oe_media_iframe/config/install/filter.format.oe_media_iframe.yml

modules/oe_media_iframe/src/Plugin/Field/FieldWidget/MediaIframeWidget.php

modules/oe_media_iframe/src/Plugin/media/Source/Iframe.php

22Alexandra · 2020-07-17T07:08:01Z

modules/oe_media_iframe/tests/src/Functional/MediaIframeFormatTest.php

+   */
+  public function testMediaSourceTextFormats(): void {
+    foreach ($this->getFixtures() as $test_data) {
+      $media = $this->storage->create([


I think it's better if you create a new media type with the iframe source to make sure the text format works for any media type instead of testing the video iframe type.

@brummbar What do you think should we build media type programmatically? Do we have plans that this particular media source could be used in other media types?

Yes it will be used in 1 more at least.

22Alexandra · 2020-07-20T14:53:29Z

modules/oe_media_iframe/oe_media_iframe.post_update.php

+ */
+function oe_media_iframe_post_update_00001() {
+  $format = \Drupal::entityTypeManager()->getStorage('filter_format')->create([
+    'format' => 'oe_media_iframe',


In theory, this should not exist but if the format "oe_media_iframe" was created by someone using this component, it will fail.

modules/oe_media_iframe/oe_media_iframe.post_update.php

modules/oe_media_iframe/config/install/core.entity_form_display.media.video_iframe.default.yml

modules/oe_media_iframe/src/Plugin/Field/FieldFormatter/MediaIframeFormatter.php

modules/oe_media_iframe/oe_media_iframe.post_update.php

… formatter.

modules/oe_media_iframe/oe_media_iframe.post_update.php

modules/oe_media_iframe/src/Plugin/Field/FieldWidget/MediaIframeWidget.php

brummbar · 2020-07-27T09:01:59Z

modules/oe_media_iframe/tests/src/Functional/MediaIframeFormatTest.php

+   */
+  public function testMediaSourceTextFormats(): void {
+    foreach ($this->getFixtures() as $test_data) {
+      $media = $this->storage->create([


Yes it will be used in 1 more at least.

modules/oe_media_iframe/oe_media_iframe.post_update.php

modules/oe_media_iframe/src/Plugin/Field/FieldWidget/MediaIframeWidget.php

modules/oe_media_iframe/src/Plugin/media/Source/Iframe.php

brummbar · 2020-07-27T14:57:05Z

modules/oe_media_iframe/tests/src/Functional/MediaIframeFormatTest.php

+  /**
+   * Test text formats selected for Media source.
+   */
+  public function testMediaSourceTextFormats(): void {


Let's make one test for the widget configuration that gets reflected in the backend. One kernel test that checks the formatter.

modules/oe_media_iframe/config/install/filter.format.oe_media_iframe.yml

…ttributes.

modules/oe_media_iframe/config/schema/oe_media_iframe.schema.yml

modules/oe_media_iframe/src/Plugin/Field/FieldFormatter/MediaIframeFormatter.php

upchuk · 2020-08-05T11:47:00Z

modules/oe_media_iframe/src/Plugin/Field/FieldWidget/MediaIframeWidget.php

+    $media_type = $this->entityTypeManager->getStorage('media_type')->load($this->fieldDefinition->getTargetBundle());
+    $text_format = $media_type->getSource()->getConfiguration()['text_format'] ?? NULL;
+
+    $element = $main_widget['value'];


@sergepavle The problem is that you are only returning the 'value' of the main widget. You add to that and return that but the problem is you then lose the top level array inside $main_widget

modules/oe_media_iframe/tests/src/Kernel/IframeFormatterTest.php

nagyad requested changes Jul 16, 2020

View reviewed changes

nagyad approved these changes Jul 16, 2020

View reviewed changes

22Alexandra reviewed Jul 16, 2020

View reviewed changes

modules/oe_media_iframe/src/Plugin/Field/FieldFormatter/MediaIframeFormatter.php Outdated Show resolved Hide resolved

22Alexandra requested changes Jul 17, 2020

View reviewed changes

22Alexandra requested changes Jul 20, 2020

View reviewed changes

22Alexandra reviewed Jul 22, 2020

View reviewed changes

modules/oe_media_iframe/src/Plugin/Field/FieldFormatter/MediaIframeFormatter.php Show resolved Hide resolved

22Alexandra reviewed Jul 23, 2020

View reviewed changes

modules/oe_media_iframe/oe_media_iframe.post_update.php Outdated Show resolved Hide resolved

sergepavle added 19 commits July 27, 2020 14:44

EWPP-82: Update configs for oe_media_iframe module.

cd640ce

EWPP-82: Update config schema.

e261b58

EWPP-82: Update module info file.

ca71f97

EWPP-82: Add upgrade path.

85bc81f

EWPP-82: Add new field widget, update existing media source and field…

a923ab1

… formatter.

EWPP-82: Add functional test and update behat.

c0da85b

EWPP-82: Fix short comment for constructor.

440dd9b

EWPP-82: Fix form element description.

b14ba92

EWPP-82: Fix type in the test method.

4fca029

EWPP-82: Fix text format name.

62a2d98

EWPP-82: Update dependencies of module.

25cc0cd

EWPP-82: Update implementation of widget.

95c7025

EWPP-82: Update functional test.

c36cf8f

EWPP-82: Update allowed tags (remove redundant global attributes).

97a4cdb

EWPP-82: Fix upgrade path.

a452779

EWPP-82: Fixes in plugins.

3e35263

EWPP-82: Update behat tests.

e2bef39

EWPP-82: Fix functional test.

a95ee28

EWPP-82: Fix return type.

8298a42

sergepavle force-pushed the EWPP-82 branch from e4b32e7 to 8298a42 Compare July 27, 2020 12:54

brummbar requested changes Jul 27, 2020

View reviewed changes

EWPP-82: Update configs for renaming field widget and limit allowed a…

ace6053

…ttributes.

sergepavle added 2 commits July 30, 2020 18:27

EWPP-82: Update post update.

47097e1

EWPP-82: Update source and field widget.

9c586cb

sergepavle force-pushed the EWPP-82 branch 2 times, most recently from af834ed to 95d6ac6 Compare July 30, 2020 16:47

EWPP-82: Add additional test coverage and update existing.

8d995e7

sergepavle force-pushed the EWPP-82 branch from 95d6ac6 to 8d995e7 Compare July 30, 2020 17:05

EWPP-82: Change invalidation of config cache.

daf151d

upchuk requested changes Aug 5, 2020

View reviewed changes

sergepavle added 4 commits August 5, 2020 15:39

EWPP-82: Extend string_textfield schema.

97a3d8a

EWPP-82: Fix iframe formatter.

d004f25

EWPP-82: Fix iframe widget.

b053c60

EWPP-82: Fix kernel test for iframe formatter.

c2e1536

sergepavle force-pushed the EWPP-82 branch from f7df893 to c2e1536 Compare August 5, 2020 13:40

sergepavle and others added 2 commits August 5, 2020 17:11

EWPP-82: Fix upgrade path.

60e8a71

EWPP-82: Showing filter tips on the iframe video widget.

6cf8348

22Alexandra approved these changes Aug 6, 2020

View reviewed changes

upchuk merged commit b7019f6 into EPIC-video-iframe-media-v2 Aug 6, 2020

upchuk deleted the EWPP-82 branch August 6, 2020 08:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

EWPP-82: Allow to configure a text format for the video iframe source. #117

EWPP-82: Allow to configure a text format for the video iframe source. #117

sergepavle commented Jul 15, 2020

22Alexandra Jul 17, 2020

sergepavle Jul 17, 2020 •

edited

Loading

brummbar Jul 27, 2020

sergepavle Jul 30, 2020

22Alexandra Jul 20, 2020

sergepavle Jul 30, 2020

brummbar Jul 27, 2020

brummbar Jul 27, 2020

sergepavle Jul 30, 2020

upchuk Aug 5, 2020

EWPP-82: Allow to configure a text format for the video iframe source. #117

EWPP-82: Allow to configure a text format for the video iframe source. #117

Conversation

sergepavle commented Jul 15, 2020

OPENEUROPA-[Insert ticket number here]

Description

Change log

Commands

Choose a reason for hiding this comment

sergepavle Jul 17, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergepavle Jul 17, 2020 •

edited

Loading