Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWPP-2023: Add a Behat step to create av portal videos programmatically. #188

Merged
merged 4 commits into from
Apr 6, 2022

Conversation

yenyasinn
Copy link
Contributor

No description provided.

22Alexandra
22Alexandra previously approved these changes Mar 14, 2022
Copy link
Contributor

@brummbar brummbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This step is not even used in this repo, this shouldn't be merged.

@yenyasinn
Copy link
Contributor Author

This step is not even used in this repo, this shouldn't be merged.

It is used in EWCMS.
What should we do - move this step there, or add some tests that use it?
It was added here since other media have such steps in oe_media

@brummbar
Copy link
Contributor

The code should be used in a test scenario, so we know that it works. Also split commited code in multiple commits based on the reason of the commit itself. The test fixes don't belong in the same commit as the behat step.

@yenyasinn yenyasinn changed the title EWPP-2023: Add "Given the following AV Portal video" command. EWPP-2023: Add a Behat step to create av portal videos programmatically. Mar 22, 2022
nagyad
nagyad previously approved these changes Mar 25, 2022
22Alexandra
22Alexandra previously approved these changes Apr 6, 2022
@brummbar brummbar dismissed their stale review April 6, 2022 15:04

My requests were implemented.

@22Alexandra 22Alexandra merged commit c761ee6 into master Apr 6, 2022
@22Alexandra 22Alexandra deleted the EWPP-2023 branch April 6, 2022 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants