Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENEUROPA-1370: Replace the functional tests with Behat in OE Media. #19

Merged
merged 11 commits into from
Dec 13, 2018

Conversation

sergepavle
Copy link
Member

@sergepavle sergepavle commented Dec 6, 2018

OPENEUROPA-1370

Description

In the OE Media component we have some functional javascript tests. These should instead be Behat tests agains the demo module to illustrate the provided capabilities in a way in which business can also understand what the component can offer.
h2. To do:

  • Replace the 4 Functional JS tests with Behat tests like the ones that already exist
  • Replace the "And I remove the media" cleanup tests with an automatic way of doing it:
  • Before and after scenario with a tag: preserveMedia
  • Before scenario that has the tag will keep track of the last Media entity ID
  • After scenario that has the tag deletes all the media entities with IDs higher than the one that was last
  • In the media-avportal-entity-browser feature, remove the empty lines at the end of the file (except the last one) -> this is a minor cleanup

@sergepavle sergepavle force-pushed the OPENEUROPA-1370 branch 2 times, most recently from 8bad31d to 0513032 Compare December 6, 2018 13:05
voidtek
voidtek previously approved these changes Dec 12, 2018
Copy link
Member

@nagyad nagyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants