Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EWPP-3721: CircaBC integration. #230

Merged
merged 1 commit into from
May 30, 2024
Merged

EWPP-3721: CircaBC integration. #230

merged 1 commit into from
May 30, 2024

Conversation

upchuk
Copy link
Contributor

@upchuk upchuk commented Dec 7, 2023

No description provided.

@upchuk upchuk force-pushed the EWPP-3721 branch 7 times, most recently from 1dd8756 to ba0b088 Compare December 13, 2023 07:50
@upchuk upchuk force-pushed the EWPP-3721 branch 3 times, most recently from 3e5d0c7 to 89a8a42 Compare February 14, 2024 14:18
description: 'Mocks the CircaBC service.'
package: OpenEuropa
type: module
core_version_requirement: ^9.4 || ^10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed anymore

description: 'Integrates the OpenEuropa Media module with the CircaBC service.'
package: OpenEuropa
type: module
core_version_requirement: ^9.4 || ^10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed anymore

protected $extensionPathResolver;

/**
* Constructs a new RssMiddleware.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nop

use Drupal\Core\Field\FormatterBase;

/**
* Plugin implementation of the 'oe_media_circabc_file_link' formatter.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect?

*/
public static function nameValueCallback(array &$element, string $input, FormStateInterface $form_state) {
$parents = array_merge($element['#field_parents'], ['oe_media_file_type']);
$value = NestedArray::getValue($form_state->getUserInput(), $parents, $exists);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$exists is undefined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats how getValue works. You pass a variable and it sets it if found.

* The form.
*/
public static function validateCircaBcUrl(&$element, FormStateInterface $form_state, &$complete_form) {
$url = NestedArray::getValue($form_state->getValues(), $element['#parents'], $input_exists);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$input_exists is undefined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

@upchuk upchuk changed the base branch from master to EPIC-EWPP-3720 May 30, 2024 09:48
@upchuk upchuk merged commit afab1dc into EPIC-EWPP-3720 May 30, 2024
1 check passed
@upchuk upchuk deleted the EWPP-3721 branch May 30, 2024 09:49
@upchuk upchuk restored the EWPP-3721 branch May 30, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants