-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EWPP-3721: CircaBC integration. #230
Conversation
1dd8756
to
ba0b088
Compare
3e5d0c7
to
89a8a42
Compare
description: 'Mocks the CircaBC service.' | ||
package: OpenEuropa | ||
type: module | ||
core_version_requirement: ^9.4 || ^10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore
description: 'Integrates the OpenEuropa Media module with the CircaBC service.' | ||
package: OpenEuropa | ||
type: module | ||
core_version_requirement: ^9.4 || ^10 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed anymore
protected $extensionPathResolver; | ||
|
||
/** | ||
* Constructs a new RssMiddleware. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nop
use Drupal\Core\Field\FormatterBase; | ||
|
||
/** | ||
* Plugin implementation of the 'oe_media_circabc_file_link' formatter. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect?
*/ | ||
public static function nameValueCallback(array &$element, string $input, FormStateInterface $form_state) { | ||
$parents = array_merge($element['#field_parents'], ['oe_media_file_type']); | ||
$value = NestedArray::getValue($form_state->getUserInput(), $parents, $exists); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$exists is undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thats how getValue works. You pass a variable and it sets it if found.
* The form. | ||
*/ | ||
public static function validateCircaBcUrl(&$element, FormStateInterface $form_state, &$complete_form) { | ||
$url = NestedArray::getValue($form_state->getValues(), $element['#parents'], $input_exists); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$input_exists is undefined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
No description provided.