OPENEUROPA-1316: Media entity video basic handling #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nagyad
changed the title
nagyad
force-pushed
the
OPENEUROPA-1316
branch
from
cb48513 to
a4d1b83
Compare
upchuk
requested changes
Oct 31, 2018
| $this->drupalGet("media/add/remote_video"); | ||
| $page->fillField("oe_media_oembed_video[0][value]", $video_url); | ||
| $page->pressButton('Save'); | ||
| $this->createScreenshot($this->root . '/screenshot.jpg'); |
There was a problem hiding this comment.
Please remove debug statement.
| * | ||
| * @var array | ||
| */ | ||
| public $videos = [ |
There was a problem hiding this comment.
Please see if we can instead use a @dataProvider method instead of a public variable with a list of video URLs.
See for example in core: UnroutedUrlTest:testIsExternal() and its provider method: providerFromUri
oe_media.module
Outdated
|
|
||
| /** | ||
| * @file | ||
| * Media module. |
There was a problem hiding this comment.
This is not the Media module.
oe_media.module
Outdated
| */ | ||
|
|
||
| /** | ||
| * Alters the information provided in \Drupal\media\Annotation\MediaSource. |
There was a problem hiding this comment.
Implements hook_media_source_info_alter().
| /** | ||
| * @file | ||
| * Media module. | ||
| */ |
There was a problem hiding this comment.
Missing strict type declaration.
oe_media.module
Outdated
| * @param array $sources | ||
| * The array of media source plugin definitions, keyed by plugin ID. | ||
| */ | ||
| function oe_media_media_source_info_alter(array &$sources) { |
sergepavle
force-pushed
the
OPENEUROPA-1316
branch
from
8988889 to
d61fe4b
Compare
upchuk
requested changes
Nov 5, 2018
oe_media.module
Outdated
| /** | ||
| * Implements hook_media_source_info_alter(). | ||
| * | ||
| * Alters the information provided in \Drupal\media\Annotation\MediaSource. |
There was a problem hiding this comment.
The information being altered is not provided inside the annotation. Only the documentation is in the that docblock. Please correct the documentation to:
Adding Daily Motion to the list of providers exposed by the OEmbed video source plugin.
upchuk
previously approved these changes
Nov 5, 2018
sergepavle
force-pushed
the
OPENEUROPA-1316
branch
from
fab0582 to
9a66234
Compare
upchuk
approved these changes
Nov 5, 2018
richardcanoe
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement remote video source type with 3 providers.