OPENEUROPA-2416: Allow to define which view modes are embedable. #79

imanoleguskiza · 2019-12-05T15:43:26Z

OPENEUROPA-2416

Description

Add functionality to define whether a media view display can be embeded or not.

Change log

Added: Add functionality to define whether a media view display can be embeded or not.
Changed:
Deprecated:
Removed:
Fixed:
Security:

Commands

[Insert commands here]

modules/oe_media_embed/src/Form/MediaEmbedDialog.php

sergepavle

I think here missed upgrade path, because, otherwise after release, possibility to embed media will be blocked.
I also have added 1 minor remark.

modules/oe_media_embed/oe_media_embed.post_update.php

modules/oe_media_embed/src/Form/MediaEmbedDialog.php

upchuk

Let's fix the new Embed view modes to have sensible defaults also in the component in terms of what fields we render. Only for newly installed sites, not also in the upgrade path. For example, the video should only show the video oEmbed and not also the created and authored fields etc.
You have a recurring typo: embedable

modules/oe_media_embed/oe_media_embed.module

modules/oe_media_embed/src/Form/MediaEmbedDialog.php

upchuk · 2020-01-09T08:19:38Z

modules/oe_media_embed/tests/FunctionalJavascript/MediaEmbedDialogTest.php

+    $this->assertSession()->pageTextContainsOnce('Selected entity');
+    $this->assertSession()->linkExists('Digital Single Market: cheaper calls to other EU countries as of 15 May');
+    $this->assertSession()->pageTextContainsOnce('There is no embedable view mode for this media type.');
+    $this->assertSession()->buttonNotExists("Embed");


Single quotes

I think needs to be done still.

modules/oe_media_embed/tests/FunctionalJavascript/MediaEmbedDialogTest.php

brummbar

Let's also improve the README of the submodule. At the moment to use this component there is a lot to do: create a text format, enable the editor on it, add the button, enable the filter and place it last (very important), allow the embeddable displays (for users). Let's add all of this in there.

modules/oe_media_embed/src/Form/MediaEmbedDialog.php

modules/oe_media_embed/oe_media_embed.module

modules/oe_media_embed/src/Form/MediaEmbedDialog.php

brummbar · 2020-01-17T10:39:55Z

modules/oe_media_embed/src/Form/MediaEmbedDialog.php

+   * @return array
+   *   The form element.
+   */
+  protected function getMediaViewModeFormElement(FormStateInterface $form_state) {


We should add the needed parameters to this method, so $entity_element and $entity, as the form state is not really needed.

We also need the embed_button from the form_state. Does that change anything? :D

Where? I cannot see it :(

brummbar

After last week meetings with the DIGIT developers, I unfortunately have to ask more changes in here.
Since now we allow to embed only the enabled view modes, existing websites will get into a state that nothing is embeddable. This was the reason that we were shipping a new embed view mode so that could embed something, but this won't be matching their current view modes and relative configuration. So we will:

ship the embed view mode only for new installations. We remove the update path creation from here. All the embed view modes must be in the optional config folder.
add an update path that allow to embed all the existing view modes (was "default" embeddable before? If not, don't add it). This will prevent any disruption for existing websites.

brummbar · 2020-01-21T13:22:39Z

modules/oe_media_embed/README.md

@@ -2,7 +2,10 @@

 The OpenEuropa Media Embed module allows the embedding of Media entities into content in an agnostic (non-Drupal) way.

-To this end, it comes with two main elements: the WYSIWYG embed button and the filter plugin.
+To this end, it comes with two main elements: the WYSIWYG embed button and the filter plugin. On top of that, it forces


It allows site administrators, while it's true that if you don't pick any you cannot embed, "forces" sounds bad.

brummbar · 2020-01-21T13:23:40Z

modules/oe_media_embed/README.md

+
+## Embeddable view modes
+
+Site adminstrators will need to define which available view modes are also available to be embedded via the tools described above.


Suggested change

Site adminstrators will need to define which available view modes are also available to be embedded via the tools described above.

Site administrators will need to define which available view modes are also available to be embedded via the tools described above.

brummbar · 2020-01-21T13:24:35Z

modules/oe_media_embed/README.md

+## Embeddable view modes
+
+Site adminstrators will need to define which available view modes are also available to be embedded via the tools described above.
+This is done by selecting the available view modes on the display mode configuration page for each available entity bundle.


Suggested change

This is done by selecting the available view modes on the display mode configuration page for each available entity bundle.

This is done by selecting the available view modes on the display mode configuration page for each available media entity bundle.

or

Suggested change

This is done by selecting the available view modes on the display mode configuration page for each available entity bundle.

This is done by selecting the available view modes on the display mode configuration page for each available media bundle.

brummbar · 2020-01-21T13:25:08Z

modules/oe_media_embed/README.md

+In order to use the functionalities of the module, first you will need to create a text format.
+You can find more information on how to do that on the official [documentation][2]
+
+Once that is done you have to make sure that:


I'd use a step (ordered/unordered list) by step procedure here.

Create a text format can stay there where you put it;

Enable the CKEditor on it;

Add the media button to the toolbar;

Enable the text filter and place it last (very important as you wrote - perfect)

Go to the media display page (not content type) (provide example link) and enable which view modes. The embed view mode is shipped and enabled by default (is it?)

brummbar · 2020-01-21T14:30:33Z

modules/oe_media_embed/tests/FunctionalJavascript/MediaEmbedDialogTest.php

+    $this->assertSession()->pageTextContainsOnce('Selected entity');
+    $this->assertSession()->linkExists('Digital Single Market: cheaper calls to other EU countries as of 15 May');
+    $this->assertSession()->pageTextContainsOnce('There is no embedable view mode for this media type.');
+    $this->assertSession()->buttonNotExists("Embed");


I think needs to be done still.

… available display.

… available view modes.

…iew modes.

…age.

…ct iframe.

imanoleguskiza force-pushed the OPENEUROPA-2416 branch from 859eb2f to ae747ca Compare December 5, 2019 15:44

sergepavle reviewed Jan 3, 2020

View reviewed changes

modules/oe_media_embed/src/Form/MediaEmbedDialog.php Outdated Show resolved Hide resolved

sergepavle requested changes Jan 3, 2020

View reviewed changes

imanoleguskiza force-pushed the OPENEUROPA-2416 branch 4 times, most recently from b44063f to 22334ad Compare January 7, 2020 15:50

sergepavle reviewed Jan 8, 2020

View reviewed changes

modules/oe_media_embed/oe_media_embed.post_update.php Outdated Show resolved Hide resolved

sergepavle reviewed Jan 8, 2020

View reviewed changes

modules/oe_media_embed/src/Form/MediaEmbedDialog.php Outdated Show resolved Hide resolved

sergepavle reviewed Jan 8, 2020

View reviewed changes

modules/oe_media_embed/src/Form/MediaEmbedDialog.php Outdated Show resolved Hide resolved

sergepavle previously approved these changes Jan 8, 2020

View reviewed changes

upchuk requested changes Jan 9, 2020

View reviewed changes

imanoleguskiza dismissed sergepavle’s stale review via a2d8ea3 January 9, 2020 14:13

imanoleguskiza force-pushed the OPENEUROPA-2416 branch from a2d8ea3 to 01b1309 Compare January 9, 2020 14:38

upchuk previously approved these changes Jan 14, 2020

View reviewed changes

brummbar requested changes Jan 17, 2020

View reviewed changes

imanoleguskiza dismissed upchuk’s stale review via 48d0523 January 20, 2020 19:10

brummbar requested changes Jan 22, 2020

View reviewed changes

imanoleguskiza force-pushed the OPENEUROPA-2416 branch 2 times, most recently from bfc971e to 9b36942 Compare January 23, 2020 11:21

upchuk force-pushed the OPENEUROPA-2416 branch 2 times, most recently from 2fff0ec to 717446c Compare January 27, 2020 07:51

upchuk previously approved these changes Jan 27, 2020

View reviewed changes

brummbar dismissed upchuk’s stale review via 9cff2da January 27, 2020 14:58

brummbar force-pushed the OPENEUROPA-2416 branch 2 times, most recently from 5721f45 to 37ca2fe Compare January 28, 2020 14:01

22Alexandra previously approved these changes Feb 18, 2020

View reviewed changes

imanoleguskiza added 3 commits February 19, 2020 15:05

OPENEUROPA-2416: Allow to define which view modes are embedable.

c318c74

OPENEUROPA-2416: Don't show the view mode select if there is only one…

53fd984

… available display.

OPENEUROPA-2416: Send the user to the view management if there are no…

64803ac

… available view modes.

imanoleguskiza and others added 22 commits February 19, 2020 15:05

OPENEUROPA-2416: Use translatable trait methods.

24bbbf1

OPENEUROPA-2416: Improve comments and descriptions.

add4ee1

OPENEUROPA-2416: Fix typo.

18799ce

OPENEUROPA-2416: Code fixes and refactoring.

3c0f59c

OPENEUROPA-2416: Update configuration.

6c5ce37

OPENEUROPA-2416: Improve test.

a0572ad

OPENEUROPA-2416: Minor test improvements.

3a94566

OPENEUROPA-2416: Move configuration to appropriate module.

3c3f7a9

OPENEUROPA-2416: Fix QA remarks.

bce78a4

OPENEUROPA-2416: Improve Readme.

3525fcb

OPENEUROPA-2416: Fix wrong code on form generation.

f6ff1ee

OPENEUROPA-2416: Change update logic.

bd9e2f5

OPENEUROPA-2416: Improve readme.

9bf3008

OPENEUROPA-2416: Minor docs improvements.

8276528

OPENEUROPA-2416: Make configuration optional.

f9dad03

OPENEUROPA-2416: Use concrete arguments on methods.

13e4872

OPENEUROPA-2416: Extract variables for entity storages.

70581c3

OPENEUROPA-2416: Missing return type.

f9bfa52

OPENEUROPA-2416: Do not ship with any default config for embeddable v…

2d89da1

…iew modes.

OPENEUROPA-2416: Add test media view modes.

41adaaf

OPENEUROPA-2416: Remove old view mode from tests.

ae23875

OPENEUROPA-2416: Update behat steps to allow more than one item per p…

6c56993

…age.

imanoleguskiza dismissed 22Alexandra’s stale review via 6c56993 February 19, 2020 15:06

imanoleguskiza force-pushed the OPENEUROPA-2416 branch from be7448b to 6c56993 Compare February 19, 2020 15:06

brummbar added 2 commits February 20, 2020 11:05

OPENEUROPA-2416: Use css attribute selectors to easily find the corre…

5f1e90f

…ct iframe.

OPENEUROPA-2416: Remove forgotten Behat test tag.

d6bd8d9

brummbar approved these changes Feb 20, 2020

View reviewed changes

22Alexandra approved these changes Feb 20, 2020

View reviewed changes

brummbar merged commit 324f738 into master Feb 20, 2020

brummbar deleted the OPENEUROPA-2416 branch February 20, 2020 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OPENEUROPA-2416: Allow to define which view modes are embedable. #79

OPENEUROPA-2416: Allow to define which view modes are embedable. #79

imanoleguskiza commented Dec 5, 2019

sergepavle left a comment •

edited

Loading

upchuk left a comment

upchuk Jan 9, 2020

brummbar Jan 21, 2020

brummbar left a comment

brummbar Jan 17, 2020

imanoleguskiza Jan 20, 2020

brummbar Jan 21, 2020

brummbar left a comment

brummbar Jan 21, 2020

brummbar Jan 21, 2020

brummbar Jan 21, 2020

brummbar Jan 21, 2020

brummbar Jan 21, 2020


		## Embeddable view modes

		Site adminstrators will need to define which available view modes are also available to be embedded via the tools described above.

	Site adminstrators will need to define which available view modes are also available to be embedded via the tools described above.
	Site administrators will need to define which available view modes are also available to be embedded via the tools described above.

	This is done by selecting the available view modes on the display mode configuration page for each available entity bundle.
	This is done by selecting the available view modes on the display mode configuration page for each available media entity bundle.

OPENEUROPA-2416: Allow to define which view modes are embedable. #79

OPENEUROPA-2416: Allow to define which view modes are embedable. #79

Conversation

imanoleguskiza commented Dec 5, 2019

OPENEUROPA-2416

Description

Change log

Commands

sergepavle left a comment • edited Loading

Choose a reason for hiding this comment

upchuk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brummbar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brummbar left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergepavle left a comment •

edited

Loading