-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OPENEUROPA-2313: Add caching of requests to AvPortal #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a64ce99
to
a7de499
Compare
sergepavle
previously approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me.
composer.json
Outdated
@@ -34,12 +34,16 @@ | |||
"post-install-cmd": "./vendor/bin/run drupal:site-setup", | |||
"post-update-cmd": "./vendor/bin/run drupal:site-setup" | |||
}, | |||
"repositories": { | |||
"drupal": { | |||
"repositories": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use patch instead of declaring repository in composer.json
6e5d1e6
to
6b420f7
Compare
Drupal never fixes the query plugin type, instead using the correct one on instanciation time. This breaks the config export validation, as the newly defined options are not found in the schema.
6b420f7
to
499b378
Compare
30642b7
to
12d592c
Compare
upchuk
approved these changes
Jan 24, 2020
sergepavle
approved these changes
Jan 24, 2020
upchuk
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.