OPENEUROPA-1325: Media entity browser handling for files #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
force-pushed
the
OPENEUROPA-1325
branch
2 times, most recently
from
9802c88 to
04c39b5
Compare
imanoleguskiza
suggested changes
Nov 20, 2018
| @@ -49,3 +49,13 @@ widgets: | |||
| weight: 3 | |||
| label: 'Add Image' | |||
| id: entity_form | |||
| e9f8e84a-9574-4de7-90de-caec7acf030d: | |||
There was a problem hiding this comment.
Why do we move this browser definition from the main module to the demo one? This doesn't seem to be the scope of the ticket
There was a problem hiding this comment.
This is decision was discussed with @upchuk . End users (site builders) could have many field which allow use only some media types. That is why common media entity browser which support all existing media type could be not relevant anymore.
sergepavle
force-pushed
the
OPENEUROPA-1325
branch
from
a2f432b to
087427d
Compare
imanoleguskiza
previously approved these changes
Nov 20, 2018
upchuk
force-pushed
the
OPENEUROPA-1325
branch
from
dbb001e to
dfc0252
Compare
upchuk
previously approved these changes
Nov 21, 2018
upchuk
force-pushed
the
OPENEUROPA-1325
branch
from
dfc0252 to
bfb44c6
Compare
voidtek
reviewed
Nov 21, 2018
| And I press the "Select entities" button | ||
| Then I should see entity browser modal window | ||
| When I click "View" | ||
| And I select the "Media document" media entity in the entity browser modal window | ||
| And I press the "Select entities" button | ||
| And I press the "Save" button | ||
| Then I should see "sample.pdf" | ||
| Then I should see the link "sample.pdf" | ||
| # Cleanup of the media entity. |
There was a problem hiding this comment.
The cleanup should be done with @afterScenario.
It's not a blocker but please create a follow-up ticket if you don't take this change it here.
voidtek
approved these changes
Nov 21, 2018
upchuk
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1325
Description
Media entity browser handling for files
Change log