template pull - disallow function creation when 'template.yml'

is not present in language template directory

Needs to add a 'template.yml' to each fake language template dir in
commands/testdata/new_function/template/<lang> in order to have current
tests pass. Deletes some unnecessary .gitignore files as a result.

Signed-off-by: Eric Stoekl <ems5311@gmail.com>

commands/new_function_test.go

@@ -30,7 +30,7 @@ const ListOptionOutput = `Languages available as templates:
 - python3
 - ruby`
 
-const LangNotExistsOutput = `(?m:bash is unavailable or not supported.)`
+const LangNotExistsOutput = `(?m:is unavailable or not supported.)`
 
 type NewFunctionTest struct {
 	title       string
@@ -52,6 +52,12 @@ var NewFunctionTests = []NewFunctionTest{
 		funcLang:    "dockerfile",
 		expectedMsg: SuccessMsg,
 	},
+	{
+		title:       "invalid_1",
+		funcName:    "new-test-invalid-1",
+		funcLang:    "dockerfilee",
+		expectedMsg: LangNotExistsOutput,
+	},
 }
 
 func runNewFunctionTest(t *testing.T, nft NewFunctionTest) {

commands/testdata/new_function/template/csharp/template.yml

@@ -0,0 +1,2 @@
+language: csharp
+fprocess: dotnet ./root.dll

commands/testdata/new_function/template/go-armhf/template.yml

@@ -0,0 +1,2 @@
+language: go-armhf
+fprocess: ./handler

commands/testdata/new_function/template/go/template.yml

@@ -0,0 +1,2 @@
+language: go
+fprocess: ./handler

commands/testdata/new_function/template/node-arm64/template.yml

@@ -0,0 +1,2 @@
+language: node-arm64
+fprocess: node index.js

commands/testdata/new_function/template/node-armhf/template.yml

@@ -0,0 +1,2 @@
+language: node-armhf
+fprocess: node index.js

commands/testdata/new_function/template/node/template.yml

@@ -0,0 +1,2 @@
+language: node
+fprocess: node index.js

commands/testdata/new_function/template/python-armhf/template.yml

@@ -0,0 +1,2 @@
+language: python-armhf
+fprocess: python index.py

commands/testdata/new_function/template/python/template.yml

@@ -0,0 +1,2 @@
+language: python
+fprocess: python index.py

commands/testdata/new_function/template/python3/template.yml

@@ -0,0 +1,2 @@
+language: python3
+fprocess: python3 index.py

commands/testdata/new_function/template/ruby/template.yml

@@ -0,0 +1,2 @@
+language: ruby
+fprocess: ruby index.rb

stack/language_template.go

@@ -53,7 +53,12 @@ func IsValidTemplate(lang string) bool {
 	if strings.ToLower(lang) == "dockerfile" {
 		found = true
 	} else if _, err := os.Stat("./template/" + lang); err == nil {
-		found = true
+		templateYAMLPath := "./template/" + lang + "/template.yml"
+
+		_, err := ParseYAMLForLanguageTemplate(templateYAMLPath)
+		if err == nil {
+			found = true
+		}
 	}
 
 	return found

stack/language_template_test.go

@@ -71,7 +71,7 @@ func Test_IsValidTemplate(t *testing.T) {
 	defer func() {
 		os.RemoveAll("template")
 	}()
-	if !IsValidTemplate("python") {
-		t.Fatalf("python must be valid")
+	if IsValidTemplate("python") {
+		t.Fatalf("python must is not valid because it does not contain template.yml")
 	}
 }