Add Go template capability for creating functions #145
Conversation
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. |
nicholasjackson
force-pushed
the
go-template
branch
from
be7d290 to
485b668
Compare
Signed-off-by: Nic Jackson <jackson.nic@gmail.com>
Signed-off-by: Nic Jackson <jackson.nic@gmail.com>
…e to add unit test excluding template Signed-off-by: Nic Jackson <jackson.nic@gmail.com>
nicholasjackson
force-pushed
the
go-template
branch
from
485b668 to
41b6340
Compare
| && curl -sSL https://github.com/openfaas/faas/releases/download/0.6.5/fwatchdog > /usr/bin/fwatchdog \ | ||
| && chmod +x /usr/bin/fwatchdog \ | ||
| && apk del curl --no-cache | ||
|
|
There was a problem hiding this comment.
one quick suggestion, some other pull requests that are pending are opting to run the functions as non-root users. some examples here by @ericstoekl #91.
There was a problem hiding this comment.
Ha, I should know that I was one of the guilty parties behind caninothazroot.
Not even following my own advice
There was a problem hiding this comment.
I have just added an additional commit which corrects this issue
|
Good point Austin. Maybe we can take that in a follow-up PR? |
Signed-off-by: Nic Jackson <jackson.nic@gmail.com>
| go build --ldflags "-s -w" -a -installsuffix cgo -o handler . && \ | ||
| go test ./... -cover | ||
|
|
||
| FROM alpine:latest |
There was a problem hiding this comment.
Please pin to 3.6 - tracking :latest might cause problems when Alpine pushes 3.7.
Description
Added capability to create functions in go, a new template has been added and the cli has been modified to allow an additional language 'Go'.
Motivation and Context
This update adds the capability to create new functions using the Go programming language using the fans-cli.
#86
How Has This Been Tested?
Unit tests have been run and a manual test has been performed creating a Go function and deploying it to OpenFaaS. The function was then load tested on the running OpenFaaS instance.
Types of changes
Checklist:
git commit -s