Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] non-root user for NodeJS template #83

Merged
merged 2 commits into from
Oct 26, 2017
Merged

[WIP] non-root user for NodeJS template #83

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
392b11c
Updated template/node/Dockerfile to run function as the `app` user fr…
austinfrey Sep 24, 2017
81ca45b
Moved adduser to line 2
austinfrey Oct 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 15 additions & 11 deletions template/node/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
FROM node:6.11.2-alpine

RUN addgroup -S app && adduser -S -g app app

# Alternatively use ADD https:// (which will not be cached by Docker builder)
RUN apk --no-cache add curl \
RUN apk --no-cache add curl \
&& echo "Pulling watchdog binary from Github." \
&& curl -sSL https://github.com/alexellis/faas/releases/download/0.6.1/fwatchdog > /usr/bin/fwatchdog \
&& chmod +x /usr/bin/fwatchdog \
Expand All @@ -12,27 +14,29 @@ WORKDIR /root/
# Turn down the verbosity to default level.
ENV NPM_CONFIG_LOGLEVEL warn

RUN mkdir -p /home/app

# Wrapper/boot-strapper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering if "user app" can go higher?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. I'll update and test

COPY package.json .
COPY package.json /home/app

WORKDIR /home/app
RUN npm i

# Function
COPY index.js .
RUN mkdir -p ./root/function
COPY index.js /home/app

COPY function/*.json ./function/
WORKDIR /root/function
COPY function/*.json /home/app/function/
WORKDIR /home/app/function
RUN npm i || :
WORKDIR /root/
COPY function function
WORKDIR /root/function
WORKDIR /home/app/
COPY function ./function

WORKDIR /root/
USER app

ENV cgi_headers="true"

ENV fprocess="node index.js"

HEALTHCHECK --interval=1s CMD [ -e /tmp/.lock ] || exit 1

CMD ["fwatchdog"]
CMD ["fwatchdog"]