Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add perl as supported language #84

Closed
wants to merge 1 commit into from
Closed

Add perl as supported language #84

wants to merge 1 commit into from

Conversation

pari-
Copy link

@pari- pari- commented Sep 6, 2017

Signed-off-by: Patrick Ringl patrick_@freenet.de

Description

OpenFAAS goes TIMTOWTDI

Motivation and Context

I love perl! ;-)

How Has This Been Tested?

Stating the obvious: by using it .. and honestly: enjoying it thus far :-)

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

PS: I deliberately rearranged the supported language enumeration where I saw fit, since ordering make enumerations much more intuitive to read - hope you don't mind, though.

regards,
pari

@pari-
Add perl as supported language
30e0a33 
Signed-off-by: Patrick Ringl <patrick_@freenet.de>
@alexellis
Copy link
Member

alexellis commented Sep 6, 2017 via email •
edited
Loading

@pari-
Copy link
Author

pari- commented Sep 6, 2017

Yup, I did. But: while playing with OpenFAAS, evaluating it as a potential first-class citizen of my actual to-be-implemented use-case, I discovered how intuitive it'd be to integrate my favourite programming language - and that's how I arrived at submitting this PR! :-)

@alexellis alexellis mentioned this pull request Sep 6, 2017
Closed
@alexellis
Copy link
Member

I'm really glad to hear that - the changes look good. We're starting to pin down the core languages which will be supported by myself and any core contributors and those which will be community-supported. Related: #86 #85

@alexellis alexellis self-requested a review September 6, 2017 21:31
@alexellis
Copy link
Member

Derek add label: revisit

@open-derek open-derek bot added the revisit label Oct 1, 2017
alexellis
alexellis requested changes Oct 5, 2017
View reviewed changes
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take this as a custom template, if you can set it up on GitHub in its own repo. In line with - #87

@pari-
Copy link
Author

pari- commented Oct 5, 2017

@alexellis will do, once #87 is merged.

@ericstoekl
Copy link
Contributor

@pari- I just tried this out but it's not giving me any output when I pass data to STDIN. This happens when calling the function directly within the container:

# echo -n stuff | carton exec perl index.pl
#

Where I would expect "Hello world from the Perl template"

Is this expected?

@alexellis
Copy link
Member

@pari- we'd like your template, but you will need to create it in its own GitHub repo. Please comment on #54 when you have that ready. I'm going to close this PR now.

@alexellis alexellis closed this Oct 23, 2017
@alexellis
Copy link
Member

@pari- please create your template.. we can support it now. Checkout the README for instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis alexellis requested changes

Assignees
No one assigned
Labels
revisit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pari- @alexellis @ericstoekl