Local run improvements #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
When there is only one function within the YAML file, run that. Print the address for the local web server. Tested whilst building a Discord bot Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
LucasRoesler
reviewed
Feb 8, 2023
|
|
||
| err = updateGitignore() |
There was a problem hiding this comment.
Is this removal just a weird diff or did you actually remove it?
When the feature was initially merged you specifically asked that the gitignore is also set during local run, to avoid committing the secrets folder. Has this changed?
There was a problem hiding this comment.
It's a change from the diff, this was copy/pasted from a different version of the command, so I'll add it back in again.
There was a problem hiding this comment.
@welteki can you send a PR to reintroduce this please?
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Local run improvements for developer experience
Motivation and Context
When there is only one function within the YAML file, run that instead of prompting for a name
Print the address for the local web server.
Improved examples and help text for the command within the CLI.
How Has This Been Tested?
Tested whilst building a Discord bot and demonstrated on the weekly office hours call
Types of changes
Checklist: