Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options field to auth section in config file #964

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

welteki
Copy link
Member

@welteki welteki commented May 17, 2023

Description

Add on options field to the auth config. This is required by the
Pro plugin to persist the settings for different oauth2 login flows.

Motivation and Context

Enable the Pro plugin to persist the settings for different oauth2 login flows.

How Has This Been Tested?

Verified the faas-cli login command is working as expected after this change.

Screenshot 2023-05-17 at 15 22 58

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

config/config_file.go Outdated Show resolved Hide resolved
Add on options field to the auth config. This is required by the
Pro plugin to persist the settings for different oauth2 login flows.

Signed-off-by: Han Verstraete (OpenFaaS Ltd) <han@openfaas.com>
@welteki welteki changed the title Add oauth2 config section to config file Add options field to auth section in config file Jun 1, 2023
Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit d7f8ff9 into openfaas:master Jun 1, 2023
@welteki welteki deleted the auth-config branch June 1, 2023 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants