Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIx requests values formatting in describe command #989

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

nitishkumar71
Copy link
Member

Description

Printing types.FunctionResources has been fixed for terminal

Motivation and Context

How Has This Been Tested?

  1. Deploy function with cpu request and memory request
    faas-cli store deploy --cpu-request 50Mi --memory-request 10Mi nodeinfo
  2. Describe function using faas-cli describe nodeinfo. The output produced should be properly formatted.
Name:               nodeinfo
Status:             Not Ready
Replicas:           1
Available Replicas: 0
Invocations:        0
Image:              ghcr.io/openfaas/nodeinfo:latest
Function Process:   <default>
URL:                http://127.0.0.1:8080/function/nodeinfo
Async URL:          http://127.0.0.1:8080/async-function/nodeinfo
Labels:
 faas_function: nodeinfo
Annotations:
 prometheus.io.scrape: false
Requests:
 CPU: 50Mi
 Memory: 10Mi

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
@alexellis alexellis merged commit f0bcb31 into openfaas:master Nov 22, 2023
1 check passed
@alexellis
Copy link
Member

Thank you @nitishkumar71 👍

@alexellis alexellis changed the title FIx request print formatting FIx requests values formatting in describe command Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FunctionResources print is not correctly formatted in describe command
2 participants