feat: allow functional nil limiter.Met implementation #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that Met() is functional when the limiter is nil. This makes it a bit easier to work with because you can assume the `cl.Met` is always callable. Reducing the number of required nil checks. Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
alexellis
reviewed
Oct 9, 2022
| @@ -11,6 +11,13 @@ import ( | |||
| "time" | |||
| ) | |||
|
|
|||
| func Test_Met_FalseWhenNil(t *testing.T) { | |||
| var cl *ConcurrencyLimiter | |||
| if cl.Met() != false { | |||
There was a problem hiding this comment.
I didn’t know it was possible to execute methods against a nil reference. TIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
Met()is functional andfalsewhen the limiter is nil. This makes it a bit easier to work with because you can assume thecl.Metis always callable. Reducing the number of required nil checks.This is helpful to simplify the implementation for openfaas/of-watchdog#144