Update ReadBasicAuth interface signature #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution. I've just checked and your commit doesn't appear to be signed-off. That's something we need before your Pull Request can be merged. Please see our contributing guide. |
Even though `ReadBasicAuth` is not used yet in the code, it looks like `BasicAuthCredentials` is supposed to satisfy it with the `Read()` method. However, the signatures differ in that the interface returns the `error` first instead of `*BasicAuthCredentials`. This could cause bugs in the future when using the interface and also is not considered idiomatic Go code. Signed-off-by: Michael Gasch <mgasch@vmware.com>
embano1
force-pushed
the
embano1-credentials
branch
from
0ca916b to
b2e892f
Compare
|
Thank you Michael, please feel free to re-vendor via https://github.com/openfaas/faas-provider/releases/tag/0.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though
ReadBasicAuthis not used yet in the code, it looks likeBasicAuthCredentialsis supposed to satisfy it with theRead()method. However, the signatures differ in that the interface returns theerrorfirst instead of*BasicAuthCredentials. This could cause bugs in the future when using the interface and also is not considered idiomatic Go code.