Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inversion in README.md for node12 and node14 links #250

Closed
g7eg10r opened this issue Apr 2, 2021 · 0 comments · Fixed by #251
Closed

Inversion in README.md for node12 and node14 links #250

g7eg10r opened this issue Apr 2, 2021 · 0 comments · Fixed by #251

Comments

@g7eg10r
Copy link

g7eg10r commented Apr 2, 2021 •
edited
Loading

Links to template source code are inverted between node12 and node14 in the README.md file.

Expected Behaviour

When I click on the "NodeJS Template" link for node12, I'm directed to the node12 directory.
When I click on the "NodeJS Template" link for node14, I'm directed to the node14 directory.

Current Behaviour

When I click on the "NodeJS Template" link for node12, I'm directed to the node14 directory.
When I click on the "NodeJS Template" link for node14, I'm directed to the node12 directory.

Possible Solution

Fix the links in README.md

Steps to Reproduce (for bugs)

  1. Access README.md on github.com
  2. Click on the "NodeJS Template" link for the node12 (resp. node14) template.
  3. Verify the name of the repository subdirectory displayed on the web page.

Context

Not relevant.

Your Environment

Not relevant.
g7eg10r pushed a commit to g7eg10r/openfaas-templates that referenced this issue Apr 2, 2021
Fixes openfaas#250.
3c75f65 
Fixed links to template directory for node12 and node14.
g7eg10r pushed a commit to g7eg10r/openfaas-templates that referenced this issue Apr 2, 2021
Fixes openfaas#250.
82633cf 
Fixed links to template directory for node12 and node14.

Signed-off-by: Guillaume Grussenmeyer <ggrussenmeyer@protonmail.com>
@g7eg10r g7eg10r mentioned this issue Apr 2, 2021
Merged
12 tasks
alexellis pushed a commit that referenced this issue Apr 6, 2021
@alexellis
Fixes #250.
813e2dc 
Fixed links to template directory for node12 and node14.

Signed-off-by: Guillaume Grussenmeyer <ggrussenmeyer@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Minor documentation fix - links to node12 and node14 in README.md g7eg10r/openfaas-templates
1 participant
@g7eg10r