Fix the values passed to the callback function for fail(). This fixes #257

[hrak]

Fix the values passed to the callback function for fail(). This fixes #257

Description

This PR makes the fail() function work the same way as success(), allowing custom status codes and return content.

Motivation and Context

• I have raised an issue to propose this change (required)

See #257 for details

Which issue(s) this PR fixes

Fixes #257

How Has This Been Tested?

• ran verify.sh
• tested with a small test function shown in nodejs12 (and nodejs14) templates only return error 500 on context.fail() #257

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Version change (see: Impact to existing users)

Impact to existing users

Existing users that rely on the current behavior of fail() always returning 500 Internal Server Error will have to alter their code.

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have signed-off my commits with git commit -s
• I have added tests to cover my changes.
• All new and existing tests passed.

[alexellis]

When do you think you can do this review and test @viveksyngh?

[alexellis]

Think of this example, it will return a HTTP 200, and I don't think that's what you wanted.

  return context
    .fail(result)

The code should probably stay the same as it is, but then change the middleware closure, with something like this:

            return res.status(fnContext.status() || 500)

[alexellis]

Can you share a handler example that we can use for an end to end test?

return context
    .fail("Not OK")

Should give 500 and "Not OK"

return context
    .succeed("OK")

Gives 200 and "OK"

return context.status(401)
    .fail("Not authorized")

Gives 401 - Not authorized

[alexellis]

See notes please

[alexellis]

@hrak please can you see the notes I posted last week?

[hrak]

@hrak please can you see the notes I posted last week?

Hi! Sorry, life happened in the meantime, in the process of buying a house. Will address this asap.

[alexellis]

Not a problem. We appreciate the contribution and it will make things better.

[alexellis]

I'm going to fix this since we've waited long enough to have it resolved and I have a few minutes to test my work at the same time.

Thanks again for your interest @hrak

If you value our work and project, consider becoming a GitHub Sponsor if you are not already.