Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support marshaling client.ClientWriteResponse #145

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

FedotCompot
Copy link
Contributor

@FedotCompot FedotCompot commented Nov 14, 2024

#144

Description

References

References: #452
Fixes: #144

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@FedotCompot FedotCompot requested a review from a team as a code owner November 14, 2024 12:02
Copy link

linux-foundation-easycla bot commented Nov 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.98%. Comparing base (e534861) to head (a314bfc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
- Coverage   26.01%   25.98%   -0.04%     
==========================================
  Files         102      102              
  Lines       12411    12405       -6     
==========================================
- Hits         3229     3223       -6     
  Misses       8911     8911              
  Partials      271      271              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense to me, but I'd like to also see what @rhamzeh thinks

@ewanharris
Copy link
Member

Confirmed with @rhamzeh that he's ok with this too.

Thanks for the PR @Fedot-Compot!

@ewanharris ewanharris changed the title Makes client.ClientWriteResponse json marshallable fix: support marshaling client.ClientWriteResponse Nov 28, 2024
@ewanharris ewanharris added this pull request to the merge queue Nov 28, 2024
Merged via the queue into openfga:main with commit 8847b87 Nov 28, 2024
5 checks passed
github-merge-queue bot pushed a commit to openfga/sdk-generator that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MarshalJSON for ClientWriteRequestWriteResponse and ClientWriteRequestDeleteResponse
3 participants