Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extraObjects #139

Merged
merged 4 commits into from
Aug 7, 2024
Merged

feat: add extraObjects #139

merged 4 commits into from
Aug 7, 2024

Conversation

danielloader
Copy link
Contributor

@danielloader danielloader commented Jun 11, 2024

Adding arbitrary manifests to the helm chart

Description

I'd like to be able to deploy other resources not included in the chart; Gateway HTTPRoutes, CloudnativePG Clusters etc.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@danielloader danielloader requested review from a team as code owners June 11, 2024 17:38
Copy link

linux-foundation-easycla bot commented Jun 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@wenzel-felix
Copy link
Contributor

@rhamzeh / @jon-whit, could you please review this PR. The changes here do not negatively impact the chart generally, but it would allow for more flexible deployments like other charts offer as well (eg. creating related secret provider classes for the Postgres uri secret).
Thanks

rhamzeh
rhamzeh previously approved these changes Jul 18, 2024
Copy link
Member

@rhamzeh rhamzeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielloader!

@danielloader
Copy link
Contributor Author

Anything else I need to do to get this merged in and released?
Thanks

@danielloader
Copy link
Contributor Author

Attempted to fix the lint failure by adding a schema entry, awaiting approval to test.

@rhamzeh rhamzeh enabled auto-merge (squash) August 7, 2024 13:35
@rhamzeh rhamzeh merged commit 0126508 into openfga:main Aug 7, 2024
4 checks passed
@danielloader danielloader deleted the extra-objects branch August 7, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants