Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add flag to wait for migrations to complete (or not) #99

Merged
merged 2 commits into from
Feb 13, 2024
Merged

feat: Add flag to wait for migrations to complete (or not) #99

merged 2 commits into from
Feb 13, 2024

Commits on Feb 13, 2024

  1. Add flag to wait for migrations to complete (or not) 

    This makes the init container that waits for migrations optional via a
`waitForMigrations` flag. If disabled, it does not render the
`initContainer` alongside the role and role binding it uses.

In tools such as ArgoCD, the waves (which can be set throught he helm
annotations we already have) ensure that a resource is applied before
another one. So this waiting init container may not be needed. Let's
make it configurable for deployments that don't require this.

Note that the option defaults to `true` as to keep the current logic and
functionality as it is.
    @JAORMX
    JAORMX committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    7588b7a View commit details
    Browse the repository at this point in the history

  2. Increase app version

    @JAORMX
    JAORMX committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    1d424e0 View commit details
    Browse the repository at this point in the history