-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests in a parallel matrix #1031
Conversation
Thanks @maukoquiroga! The promise of such a speed improvement is exciting, and I would be very appreciative of a refactor / overhaul of the current test runner 😃 However, I must say that the changeset is pretty daunting, and seems to have impacts way beyond the test runner, with some core functions having their visibility changed… Could we maybe convene of a video discussion with other interested @openfisca/international-contrib contributors, in order to understand the goals, side effects and side benefits? 🙂 In terms of pure performance and parallelisation, it might also be that #1030 allows us to use https://github.com/nektos/act as suggested by @benoit-cty, and we could have local parallelisation with the exact same setup as CI, which I would be very excited about 😃 |
Some of them were absolutely required, in which case I've tried to avoid a breaking change by exposing changes through Indeed a partial refactoring of the test runner was imposed in order to make this work, which could definitely go in a PR on its own, with proper deprecations, and agreed upon breaking changes.
❤️
Definitely. |
f4ad3ab
to
5f5150b
Compare
1471701
to
8f37594
Compare
Closing for now. |
Hello!
(Working) prototype for solving #1025 and #1035, poke #1027, please chime in! 😄
⚠ This is not a proposal but a demonstration of the different tools, so we can discuss and choose what make more sense in terms both of performance and readability to the community.
Trying it out
New features
openfisca test
tests in parallel withmake
,nox
, andinvoke
Notes
threadsafe
, so each subprocess will run a single threadTODO
invoke
nox
make
pytest-parallel
pytest-split