Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

Fix id is readonly when update distrib #46

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

glutamatt
Copy link
Contributor

@glutamatt glutamatt commented Nov 5, 2021

Description

a quick and dirty patch to respect flagr api when updating distributions

Motivation and Context

image

How Has This Been Tested?

i tried the ui, by hand, checked the http request with chrome dev tool, in a dev env in my company

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2021

Codecov Report

Merging #46 (16b6fa3) into main (1694d8e) will increase coverage by 2.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
+ Coverage   81.55%   83.74%   +2.18%     
==========================================
  Files          27       28       +1     
  Lines        2174     2356     +182     
==========================================
+ Hits         1773     1973     +200     
+ Misses        314      299      -15     
+ Partials       87       84       -3     
Impacted Files Coverage Δ
pkg/entity/logger.go 46.66% <0.00%> (ø)
pkg/handler/eval.go 87.09% <0.00%> (+0.31%) ⬆️
pkg/handler/crud.go 91.55% <0.00%> (+5.33%) ⬆️
pkg/handler/data_recorder_kafka.go 79.54% <0.00%> (+6.90%) ⬆️
pkg/handler/export.go 73.17% <0.00%> (+9.40%) ⬆️
pkg/entity/db.go 88.52% <0.00%> (+14.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1694d8e...16b6fa3. Read the comment docs.

@github-actions
Copy link

Stale pull request message

Copy link
Contributor

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, makes sense, actually the distribution should always be created instead of reusing the old id.

@zhouzhuojie zhouzhuojie merged commit 60cc8db into openflagr:main Mar 4, 2022
@glutamatt glutamatt deleted the editdistribfix branch March 4, 2022 10:53
@glutamatt
Copy link
Contributor Author

thanks @zhouzhuojie for this merge and the whole work on flagr
i work at deezer.com and your project is insanely useful

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants