Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use web prefix for main API #234

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Use web prefix for main API #234

merged 1 commit into from
Mar 20, 2019

Conversation

zhouzhuojie
Copy link
Collaborator

Description

Fix #225. Context is that UI's api path can be relative, and we can also prefix our main api with FLAGR_WEB_PREFIX

Motivation and Context

How Has This Been Tested?

Tested locally with and without FLAGR_WEB_PREFIX

FLAGR_WEB_PREFIX='/foo' make run

image

make run

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Although breaking changes to the behavior of FLAGR_WEB_PREFIX, but the scope should be small, since it only applies to deployment after #222

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-io
Copy link

Codecov Report

Merging #234 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
- Coverage   83.87%   83.76%   -0.12%     
==========================================
  Files          24       24              
  Lines        1433     1435       +2     
==========================================
  Hits         1202     1202              
- Misses        174      175       +1     
- Partials       57       58       +1
Impacted Files Coverage Δ
pkg/config/middleware.go 74.8% <0%> (-1.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65fd5b9...88c5da0. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit 8f3c10d into master Mar 20, 2019
@zhouzhuojie zhouzhuojie deleted the zz/change-web-prefix branch March 20, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebPrefix does not update API_URL
3 participants