Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option FLAGR_RECORDER_KAFKA_PARTITION_KEY_ENABLED #535

Merged

Conversation

paragor
Copy link
Contributor

@paragor paragor commented Jun 22, 2023

Description

Add option FLAGR_RECORDER_KAFKA_PARTITION_KEY_ENABLED

Motivation and Context

We have entity id that contains only user's segment. When google bot come to our site we have many messages in only one partition in kafka. This pull request disable key partition, so messages come to random partition but without order guarantee.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@foxdalas
Copy link
Contributor

@zhouzhuojie interesting PR!

@codecov-commenter
Copy link

Codecov Report

Merging #535 (6f042ac) into main (347a36d) will decrease coverage by 0.10%.
The diff coverage is 62.50%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
- Coverage   80.96%   80.87%   -0.10%     
==========================================
  Files          28       28              
  Lines        2222     2227       +5     
==========================================
+ Hits         1799     1801       +2     
- Misses        334      336       +2     
- Partials       89       90       +1     
Impacted Files Coverage Δ
pkg/handler/data_recorder_kafka.go 72.41% <62.50%> (-1.47%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nothing0012 nothing0012 merged commit 8bfa0cc into openflagr:main Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants