Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cors max age #563

Merged
merged 2 commits into from
Jan 1, 2024
Merged

Add cors max age #563

merged 2 commits into from
Jan 1, 2024

Conversation

nothing0012
Copy link
Contributor

Description

To add MaxAge config to the cors to save some browser preflight OPTION calls.

Motivation and Context

To optimize browser client performance

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

go.mod Outdated
@@ -56,7 +56,6 @@ require (

require (
cloud.google.com/go/pubsub v1.30.0
github.com/goccy/go-json v0.10.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was not used, this is running make vendor as cleanup step

@ghost
Copy link

ghost commented Dec 31, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3f9f613) 81.18% compared to head (2015aab) 81.19%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #563   +/-   ##
=======================================
  Coverage   81.18%   81.19%           
=======================================
  Files          28       28           
  Lines        2270     2271    +1     
=======================================
+ Hits         1843     1844    +1     
  Misses        337      337           
  Partials       90       90           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nothing0012 nothing0012 merged commit 3e4fb4a into main Jan 1, 2024
9 checks passed
@nothing0012 nothing0012 deleted the zz/add-cors-max-age branch January 1, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants