Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Upload Smoothie's metadata to Google PlayStore #3

Merged
merged 59 commits into from
May 8, 2022
Merged

feat: Upload Smoothie's metadata to Google PlayStore #3

merged 59 commits into from
May 8, 2022

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Oct 15, 2021 •
edited
Loading

What

  • Upload metadata to PlayStore
  • Set up secrets
  • Do the same for iOS

Part of

@teolemon teolemon mentioned this pull request Jan 22, 2022
Open
M123-dev
M123-dev suggested changes Jan 23, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments

.github/workflows/validate-metadata.yml Outdated
validate:
- name: Decrypt API JSON file
runs-on: ubuntu-latest
run: cd ./packages/smooth_app/android/fastlane/envfiles && chmod +x ./decrypt_secrets.sh && ./decrypt_secrets.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be changed

.github/workflows/validate-metadata.yml Outdated
run: cd ./packages/smooth_app/android/fastlane/envfiles && chmod +x ./decrypt_secrets.sh && ./decrypt_secrets.sh
env:
API_JSON_FILE_DECRYPTKEY: ${{ secrets.API_JSON_FILE_DECRYPTKEY }}
STORE_JKS_DECRYPTKEY: ${{ secrets.STORE_JKS_DECRYPTKEY }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets put the validation before the encryption

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@teolemon teolemon changed the title Upload metadata to PlayStore Upload metadata to Google PlayStore Jan 23, 2022
M123-dev
M123-dev approved these changes Jan 23, 2022
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the filename the the path to the credentials everything looks good by now 👍🏼

.github/workflows/validate-metadata.yml Outdated Show resolved Hide resolved
@teolemon
Copy link
Member Author

teolemon commented Jan 23, 2022 •
edited
Loading

@teolemon teolemon changed the title Upload metadata to Google PlayStore feat: Upload metadata to Google PlayStore Mar 17, 2022
@teolemon teolemon added this to the V1 milestone Apr 17, 2022
@teolemon teolemon changed the title feat: Upload metadata to Google PlayStore feat: Upload Smoothie's metadata to Google PlayStore Apr 22, 2022
@teolemon teolemon self-assigned this Apr 25, 2022
teolemon
teolemon commented May 8, 2022
View reviewed changes
fastlane/Fastfile Outdated Show resolved Hide resolved
teolemon
teolemon commented May 8, 2022
View reviewed changes
fastlane/Appfile Outdated Show resolved Hide resolved
teolemon
teolemon commented May 8, 2022
View reviewed changes
fastlane/Fastfile Outdated Show resolved Hide resolved
@teolemon teolemon merged commit 4128718 into main May 8, 2022
@teolemon teolemon deleted the upload-to-playstore branch May 8, 2022 19:58
@teolemon teolemon mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees

@teolemon teolemon

Labels
playstore
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging this pull request may close these issues.
2 participants
@teolemon @M123-dev