[2870] Add an in-app changelog #3810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naivekook
commented
Feb 5, 2021
| .observeOn(AndroidSchedulers.mainThread()) | ||
| .subscribe( | ||
| { items -> recyclerView.adapter = ChangelogAdapter(items) }, | ||
| { throwable -> throwable.printStackTrace() } |
There was a problem hiding this comment.
Do we need to log this somehow?
naivekook
commented
Feb 5, 2021
| @@ -420,6 +421,10 @@ class MainActivity : BaseActivity(), NavigationDrawerListener { | |||
| binding.bottomNavigationInclude.bottomNavigation.selectNavigationItem(0) | |||
| binding.bottomNavigationInclude.bottomNavigation.installBottomNavigation(this) | |||
| handleIntent(intent) | |||
|
|
|||
| if (isFlavors(AppFlavors.OFF)) { | |||
naivekook
force-pushed
the
feature/add-changelog-screen
branch
from
f338d81 to
836b148
Compare
teolemon
force-pushed
the
feature/add-changelog-screen
branch
from
0594542 to
a6ab8af
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Not yet, but it looks good. My biggest concern was architecture wise (so that we don't show the message twice, and that we have a simple translation path) |
|
@naivekook isn't there anything to use the resources created by fastlane with the |
|
@VaiTon sorry I don't understand the question |
|
Ok, let's merge and debug in the internal release 👍 YOLO :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add new screen to show all our new functionality to users in a fancy way.
Related issues
Linked issue #{2870}
Related PRs
Screenshots