Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature_2/#191 - added eco-score and nutri-score categories (ProductImprovement) #288

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • Product.dart

…ies (ProductImprovement)

Impacted file:
* `Product.dart`
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@M123-dev
Copy link
Member

Just one sidenote @monsieurtanuki, the changelog is going to be created by release-please and it doesn't leave much tolerance for commit names (in my testing, even a capital F at fix: was not accepted), so I assume that such names as this will not be automatically included.

@monsieurtanuki monsieurtanuki merged commit 797339d into openfoodfacts:master Nov 12, 2021
@monsieurtanuki
Copy link
Contributor Author

@M123-dev Oh, I wasn't aware of that. In that case a correct title would have been "feat: #191 - added eco-score and nutri-score categories (ProductImprovement)", am I right?

@M123-dev
Copy link
Member

@monsieurtanuki according to the dokumentaion it looks right. With a little testing, we will quickly find the right syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants