Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: #307 - added 21 enum values for advanced search parameters #313

Merged
merged 1 commit into from
Dec 12, 2021
Merged

feat: #307 - added 21 enum values for advanced search parameters #313

merged 1 commit into from
Dec 12, 2021

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • api_searchProduct_test.dart: additional tests on all TagFilterTypes; refactoring
  • TagFilter.dart: added more explicit enum TagFilterType as filter types

@monsieurtanuki
feat: openfoodfacts#307 - added 21 enum values for advanced search pa…
6de37b2 
…rameters

Impacted files:
* `api_searchProduct_test.dart`: additional tests on all `TagFilterType`s; refactoring
* `TagFilter.dart`: added more explicit `enum TagFilterType` as filter types
M123-dev
M123-dev approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@M123-dev M123-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @monsieurtanuki 👍🏼

@monsieurtanuki monsieurtanuki merged commit 55f3fa5 into openfoodfacts:master Dec 12, 2021
@monsieurtanuki
Copy link
Contributor Author

Thank you @M123-dev!

@monsieurtanuki monsieurtanuki linked an issue Dec 12, 2021 that may be closed by this pull request
Allow for advanced search queries #307
Closed
@monsieurtanuki monsieurtanuki mentioned this pull request Dec 12, 2021
Closed
@monsieurtanuki
Copy link
Contributor Author

Hey @M123-dev, I've just received an email about version 1.6.0. Isn't that a bit generous to go from 1.4.0 to 1.6.0 in just a couple of feat:? Will your PR about country code also move us up to 1.7.0?

@M123-dev
Copy link
Member

@monsieurtanuki we just released 1.5.0 yesterday, with getProductUri and setProductImageAngle (It was the first working automatic release #312) so it is not a jump.

But yes a already moving up to 1.6.0 is a bit quick but luckily the version increase only happens when we merge the autorelease PR, that means we can merge as many feats and fixes as we want and the PR stays at 1.6.0, only with a breaking change (feat!: or fix!:) it would increase to 2.0.0.

Same goes for fixes, when we have x fixes merges the version goes only up by 0.0.1

@monsieurtanuki
Copy link
Contributor Author

Ok thank you @M123-dev that's clearer. The version increase makes sense, and the fact that we still have control on when to actually release too (with the autorelease PR).

@teolemon teolemon mentioned this pull request Jan 21, 2022
Open
@teolemon teolemon mentioned this pull request Mar 28, 2022
Open
59 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M123-dev M123-dev M123-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for advanced search queries
2 participants
@monsieurtanuki @M123-dev