feat: #531 - new StatesTagsParameter search filter #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `State.dart`: States of a `Product`. To be used in search API, with `StatesTagsParameter`. * `StatesTagsParameter.dart`: States Tags as completed or to-be-completed. Filter combo mode is 'AND'. Impacted file: * `api_searchProducts_test.dart`: added a group of tests around the new parameter `StatesTagsParameter`
This was referenced Jul 29, 2022
M123-dev
approved these changes
Aug 3, 2022
| import 'package:openfoodfacts/interface/Parameter.dart'; | ||
| import 'package:openfoodfacts/model/State.dart'; | ||
|
|
||
| /// States Tags as completed or to-be-completed. Filter combo mode is 'AND'. |
There was a problem hiding this comment.
Again, can't tell what a "Filter combo mode" is
There was a problem hiding this comment.
@M123-dev Fair enough; I've changed the comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files:
State.dart: States of aProduct. To be used in search API, withStatesTagsParameter.StatesTagsParameter.dart: States Tags as completed or to-be-completed. Filter combo mode is 'AND'.Impacted file:
api_searchProducts_test.dart: added a group of tests around the new parameterStatesTagsParameterWhat
StatesTagsParametersearch filter.Stateenum, that lists the possible states. For each state, you'll have to say if it's completed or to-be-completed.Closes issue