feat: 539 - taxonomy for Nova groups #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New files: * `api_getTaxonomyNovaServer_test.dart`: Integration test about nova. * `TaxonomyNova.dart`: A JSON-serializable version of a Nova taxonomy result. * `TaxonomyNova.g.dart`: generated Impacted files: * `api_searchProducts_test.dart`: unrelated refactoring in order to make that test more re-testable * `LICENSE`: unrelated minor fix * `openfoodfacts.dart`: new method `getTaxonomyNova` * `TagType.dart`: added an entry for "nova"
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
- Coverage 68.58% 68.10% -0.48%
==========================================
Files 185 197 +12
Lines 7598 7833 +235
==========================================
+ Hits 5211 5335 +124
- Misses 2387 2498 +111
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Impacted file: * `api_getToBeCompletedProducts_test.dart`
teolemon
approved these changes
Dec 17, 2022
|
Thank you @teolemon! |
teolemon
added
🧬 Taxonomies
NOVA groups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New files:
api_getTaxonomyNovaServer_test.dart: Integration test about nova.TaxonomyNova.dart: A JSON-serializable version of a Nova taxonomy result.TaxonomyNova.g.dart: generatedImpacted files:
api_searchProducts_test.dart: unrelated refactoring in order to make that test more re-testableLICENSE: unrelated minor fixopenfoodfacts.dart: new methodgetTaxonomyNovaTagType.dart: added an entry for "nova"What
getTaxonomyNova, with of course limited outputs (only 4 items)Part of