feat: simplified access to raw product images #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `api_get_product_image_ids_test.dart`: used new method and extended tests to all/main/raw images * `api_get_product_test.dart`: minor refactoring * `api_json_to_from_test.dart`: extended tests to all/main/raw images * `image_helper.dart`: minor refactoring * `json_helper.dart`: integrated "raw" images in addition to "main" images * `open_food_api_client.dart`: deprecated method `getProductImageIds` * `product.dart`: integrated "raw" images in addition to "main" images * `product.g.dart`: generated * `product_helper.dart`: minor refactoring * `product_image.dart`: now can include "raw" images
M123-dev
approved these changes
Dec 23, 2023
There was a problem hiding this comment.
Thanks a lot @monsieurtanuki, I like the new implementation way more without the helper class.
I've clarified some comments as I was kinda confused by them without reading the doc comment for ProductImage. Feel free to have a look at them
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #839 +/- ##
==========================================
- Coverage 75.93% 75.87% -0.07%
==========================================
Files 224 224
Lines 7817 7880 +63
==========================================
+ Hits 5936 5979 +43
- Misses 1881 1901 +20 ☔ View full report in Codecov by Sentry. |
|
Thank you @M123-dev for your review! I've changed the comments according to your suggestions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
images, that used to have only "main" pictures for historical reasons.IMAGESproduct field.Part of
Impacted files
api_get_product_image_ids_test.dart: used new method and extended tests to all/main/raw imagesapi_get_product_test.dart: minor refactoringapi_json_to_from_test.dart: extended tests to all/main/raw imagesimage_helper.dart: minor refactoringjson_helper.dart: integrated "raw" images in addition to "main" imagesopen_food_api_client.dart: deprecated methodgetProductImageIdsproduct.dart: integrated "raw" images in addition to "main" imagesproduct.g.dart: generatedproduct_helper.dart: minor refactoringproduct_image.dart: now can include "raw" images