Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: folksonomy getProductTag may return 404 #881

Merged

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Recent change in folksonomy, server-side (couple of days ago): unknown product tag search will return 404.
  • This PR deals with it.
❌ test/api_folksonomy_test.dart: OpenFoodAPIClient Folksonomy getProductTag - not found (failed)
  Exception: Wrong status code: 404
  package:openfoodfacts/src/folksonomy.dart 373:7  FolksonomyAPIClient._checkResponse
  package:openfoodfacts/src/folksonomy.dart 172:5  FolksonomyAPIClient.getProductTag
  ===== asynchronous gap ===========================
  test/api_folksonomy_test.dart 134:36             main.<fn>.<fn>
```

@monsieurtanuki monsieurtanuki merged commit 990cc67 into openfoodfacts:master Feb 13, 2024
4 of 5 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants