Skip to content
This repository has been archived by the owner on Jul 6, 2022. It is now read-only.

WIP: Add i18n #56

Merged
merged 7 commits into from
Jul 17, 2020
Merged

WIP: Add i18n #56

merged 7 commits into from
Jul 17, 2020

Conversation

astagi
Copy link
Member

@astagi astagi commented Jul 8, 2020

This PR adds i18n support. It's a work in progress, cause it needs some things to be completed:

@astagi astagi mentioned this pull request Jul 8, 2020
2 tasks
Copy link
Collaborator

@raphael0202 raphael0202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR 👍, I've added a few comments

src/components/Product.vue Outdated Show resolved Hide resolved
src/views/SettingsView.vue Show resolved Hide resolved
src/i18n/messages.js Outdated Show resolved Hide resolved
src/i18n/en.js Outdated Show resolved Hide resolved
src/components/AnnotationCounter.vue Outdated Show resolved Hide resolved
@raphael0202
Copy link
Collaborator

Sorry I didn't see this was a WIP

@astagi
Copy link
Member Author

astagi commented Jul 9, 2020

No problem @raphael0202 I updated the PR with new translations and the requested changes

@astagi astagi requested a review from raphael0202 July 10, 2020 13:52
@astagi
Copy link
Member Author

astagi commented Jul 11, 2020

@raphael0202 I marked "Understand how to get the correct view and edit urls based on language." as done, looks like @teolemon is working to fix the problem in #57

@teolemon
Copy link
Member

Erm I'm very unfamilar with Vue.JS. Feel free to fix the issue in this pr
image

@teolemon
Copy link
Member

But the PR already LGTM to me

@astagi
Copy link
Member Author

astagi commented Jul 11, 2020

@teolemon that's good ✌🏻 Also if 'en' is the only case where view and edit links fail, you can write that part of code with a single line expression

`https://world${lang === 'en' ? '' : '-' + lang}.openfoodfacts.org/product/${barcode}`

@raphael0202
Copy link
Collaborator

Sorry for the delay. A few translations are missing in en.json for the logo search page, but I will add them manually. Merging, thank you!

@raphael0202 raphael0202 merged commit 1e2e9c2 into openfoodfacts:master Jul 17, 2020
@astagi
Copy link
Member Author

astagi commented Jul 17, 2020

Thanks @raphael0202 👍 sorry for missing translations, I didn't see them 👀 I'll check the missing item "Define a list of languages the app should support", supported languages can be added manually later

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants