-
-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR 👍, I've added a few comments
Sorry I didn't see this was a WIP |
No problem @raphael0202 I updated the PR with new translations and the requested changes |
@raphael0202 I marked "Understand how to get the correct view and edit urls based on language." as done, looks like @teolemon is working to fix the problem in #57 |
But the PR already LGTM to me |
@teolemon that's good ✌🏻 Also if 'en' is the only case where `https://world${lang === 'en' ? '' : '-' + lang}.openfoodfacts.org/product/${barcode}` |
Sorry for the delay. A few translations are missing in en.json for the logo search page, but I will add them manually. Merging, thank you! |
Thanks @raphael0202 👍 sorry for missing translations, I didn't see them 👀 I'll check the missing item "Define a list of languages the app should support", supported languages can be added manually later |
This PR adds i18n support. It's a work in progress, cause it needs some things to be completed:
view
andedit
urls based on language. The current interpolation underoff.js
doesn't work for some languages (e.g. https://world-en.openfoodfacts.org/cgi/product.pl?type=edit&code=26041254 gives an error)