Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistant normalization prevents linked knowledge panels from working #6810

Closed
teolemon opened this issue May 22, 2022 · 0 comments · Fixed by #6815
Closed

Inconsistant normalization prevents linked knowledge panels from working #6810

teolemon opened this issue May 22, 2022 · 0 comments · Fixed by #6815
Assignees
@stephanegigandet
Labels
🐛 bug This is a bug, not a feature request. 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 🎯 P0
Milestone
Smoothie Launch (...

Comments

@teolemon
Copy link
Member

teolemon commented May 22, 2022 •
edited
Loading

What

vegan/vegetarian/palm oil should already be working, and they don't seem to. It's related to inconsistant normalization.

Product API output

https://world.openfoodfacts.org/api/v2/product/4006544205006.json?fields=knowledge_panels,attributes
https://world.openfoodfacts.org/api/v2/product/4006544205006.json?fields=knowledge_panels,attributes_groups
"panel_element":{"panel_id":"ingredients_analysis_en:vegan"}

Attributes API output

https://world.openfoodfacts.org/api/v2/product/4337185341373/k-take-it-veggie-vegan-nuggets?fields=knowledge_panels,attribute_groups
{"attributes":[{"grade":"a","icon_url":"https://static.openfoodfacts.dev/images/attributes/vegan.svg","id":"vegan","match":100,"name":"Vegan","panel_id":"ingredients_analysis_en-vegan","status":"known","title":"Vegan"}

Who for

Smoothie users

Part of
@teolemon teolemon added the ♞ Epic An epic groups several tasks/issues. It should have a meaning for users. label May 22, 2022
@teolemon teolemon added 🐛 bug This is a bug, not a feature request. 🎯 P0 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels and removed ♞ Epic An epic groups several tasks/issues. It should have a meaning for users. labels May 22, 2022
@teolemon teolemon moved this from To discuss and validate to Todo (ready 2 dev) in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 22, 2022
@teolemon teolemon changed the title inconsistant normalization prevents linked knowledge panels from working Inconsistant normalization prevents linked knowledge panels from working May 22, 2022
@stephanegigandet stephanegigandet self-assigned this May 23, 2022
stephanegigandet added a commit that referenced this issue May 23, 2022
@stephanegigandet
fix: make panel ids consistent for ingredients analysis knowledge pan…
9c3a68a 
…els #6810
@stephanegigandet stephanegigandet mentioned this issue May 23, 2022
Merged
stephanegigandet added a commit that referenced this issue May 30, 2022
@stephanegigandet
fix: make panel ids consistent for ingredients analysis knowledge pan…
726fb92 
…els (#6815)

* fix: make panel ids consistent for ingredients analysis knowledge panels #6810

* update tests
Repository owner moved this from Todo (ready 2 dev) to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) May 30, 2022
Repository owner moved this from In Progress to Done in 🍊 Open Food Facts Server issues May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stephanegigandet stephanegigandet

Labels
🐛 bug This is a bug, not a feature request. 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels 🎯 P0
Projects
Product Opener - Sprint
Archived in project
🍊 Open Food Facts Server issues
Archived in project
📖 Knowledge panels
Status: To do
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
Smoothie Launch (server readiness)
2 participants
@teolemon @stephanegigandet