fix: Update footer icon and URL #11128
Conversation
github-actions
bot
added
Template::Toolkit
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11128 +/- ##
==========================================
+ Coverage 40.64% 49.03% +8.38%
==========================================
Files 77 78 +1
Lines 22316 22374 +58
Branches 5354 5363 +9
==========================================
+ Hits 9071 10971 +1900
+ Misses 12067 10058 -2009
- Partials 1178 1345 +167 ☔ View full report in Codecov by Sentry. |
|
/update_tests_results |
1 similar comment
|
/update_tests_results |
| <a href="' _ facebook_page_url _ '"><img src="/images/icons/dist/facebook.svg" class="footer_social_icon" alt="Facebook"></a> | ||
| <a href="https://www.instagram.com/open.food.facts/"><img src="/images/icons/dist/instagram.svg" class="footer_social_icon" alt="Instagram"></a> | ||
| <a href="https://x.com/OpenFoodFacts"><img src="/images/icons/dist/x.svg" class="footer_social_icon" alt="X"></a> | ||
| <a href="https://facebook.com/OpenFoodFacts"><img src="/images/icons/dist/facebook.svg" class="footer_social_icon" alt="Facebook"></a> |
There was a problem hiding this comment.
I think '_ facebook_page_url _' and ' _ twitter_account _ ' are placeholders and replaced somehow. Thus, they should probably stay the same in this template.
| <a href="https://twitter.com/' _ twitter_account _ '"><img src="/images/icons/dist/twitter.svg" class="footer_social_icon" alt="Twitter"></a> | ||
| <a href="' _ facebook_page_url _ '"><img src="/images/icons/dist/facebook.svg" class="footer_social_icon" alt="Facebook"></a> | ||
| <a href="https://www.instagram.com/open.food.facts/"><img src="/images/icons/dist/instagram.svg" class="footer_social_icon" alt="Instagram"></a> | ||
| <a href="https://x.com/OpenFoodFacts"><img src="/images/icons/dist/x.svg" class="footer_social_icon" alt="X"></a> |
There was a problem hiding this comment.
We don't have x.svg in icons/. It would probably be best to add it in addition to https://github.com/openfoodfacts/openfoodfacts-server/blob/6456ca4775e69431eccf4d658acd07513b33cad0/icons/twitter.svg
|
|
Are the above changes satisfactory? @hangy |
What
Updated the social media icon in the footer to reflect the latest branding changes from Twitter to X. The URL has also been updated to
https://x.com/OpenFoodFacts.Related issue(s) and discussion