Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Fix category taxonomy warnings #11167

Merged
merged 12 commits into from
Dec 27, 2024
Merged

Conversation

raphael0202
Copy link
Contributor

Fix taxonomy errors and warning spotted using the Taxonomy editor:

Capture d’écran du 2024-12-23 08-50-17

The only one remaining is this one: WARNING: Entry with same id fr:terrines-foie-volaille already exists, duplicate id in file at line 116496. The two nodes will be merged, keeping the last values in case of conflicts.

It looks like Terrines de foie de volaille and Terrines au foie de volaille are merged into the same entity due to stopwords, I'm not sure how to fix this one.

@raphael0202 raphael0202 requested a review from aleene December 23, 2024 07:52
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Dec 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.03%. Comparing base (a0a975a) to head (7aa3c88).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11167   +/-   ##
=======================================
  Coverage   49.03%   49.03%           
=======================================
  Files          78       78           
  Lines       22374    22374           
  Branches     5363     5363           
=======================================
  Hits        10971    10971           
  Misses      10058    10058           
  Partials     1345     1345           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphael0202 raphael0202 requested a review from teolemon December 26, 2024 17:42
Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @raphael0202

@@ -63911,18 +63905,6 @@ hr: Pšenični škrob
lt: Kviečių krakmolas
nl: Tarwezetmelen

< en:Starches
en: Tapioca
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: Dupe to check

@@ -65890,6 +65874,10 @@ nl: Diepvries hartige taarten
en: Frozen quiches
fr: Quiches surgelées, Quiches salées surgelées

< en:Meals
en: Combination Meals
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: check

@@ -107267,10 +107240,6 @@ fr: Pomme de terre Bintje
hr: Bintje krumpir
nl: Bintje aardappelen

< en:Potatoes
en: Lady Christl potatoes
fr: Pomme de terre Lady Christl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted ?

@raphael0202 raphael0202 merged commit a033056 into main Dec 27, 2024
15 checks passed
@raphael0202 raphael0202 deleted the fix-category-taxonomy-warnings branch December 27, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants