fix: Pop loading dialog before build is finished (#1182)

* fix: Pop loading dialog before build is finished * Update image_crop_page.dart
openfoodfacts · Mar 4, 2022 · d7b36bd · d7b36bd
1 parent 05081ab
commit d7b36bd
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/packages/smooth_app/lib/generic_lib/loading_dialog.dart b/packages/smooth_app/lib/generic_lib/loading_dialog.dart
@@ -1,4 +1,5 @@
 import 'package:flutter/material.dart';
+import 'package:flutter/scheduler.dart';
 import 'package:flutter_gen/gen_l10n/app_localizations.dart';
 import 'package:smooth_app/generic_lib/buttons/smooth_action_button.dart';
 import 'package:smooth_app/generic_lib/dialogs/smooth_alert_dialog.dart';
@@ -61,7 +62,6 @@ class LoadingDialog<T> {
           future.then<void>(
             (final T value) => _popDialog(context, value),
           );
-          // TODO(monsieurtanuki): is that safe? If the future finishes before the "return" call?
           return _getDialog(context, title);
         },
       );
@@ -72,8 +72,11 @@ class LoadingDialog<T> {
       return;
     }
     _popEd = true;
-    // Here we use the root navigator so that we can pop dialog while using multiple navigators.
-    Navigator.of(context, rootNavigator: true).pop(value);
+    // To avoid returning before the alertDialog is build
+    SchedulerBinding.instance?.addPostFrameCallback((_) {
+      // Here we use the root navigator so that we can pop dialog while using multiple navigators.
+      Navigator.of(context, rootNavigator: true).pop(value);
+    });
   }
 
   /// Displayed dialog during future.