feat: #41 - now storing preference references (for the next app start) #1007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main goal is to avoid screen flickering at app start time, when the preference references are downloaded and notify a refresh (again and again everyday, with the same language). New file: * `downloadable_string.dart`: Downloadable String that may be stored (and compared to the previous value). Impacted files: * `main.dart`: refactored * `product_preferences.dart`: created explicit methods `init` and `refresh`; now stores locally the downloaded strings, that will be reused for the next app start * `user_preferences_page_test.dart`: refactored
M123-dev
approved these changes
Jan 24, 2022
|
Thank you @M123-dev for your code review! Indeed, there are other places in smoothie where caching strings will be interesting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main goal is to avoid screen flickering at app start time, when the preference references are downloaded and notify a refresh (again and again everyday, with the same language).
New file:
downloadable_string.dart: Downloadable String that may be stored (and compared to the previous value).Impacted files:
main.dart: refactoredproduct_preferences.dart: created explicit methodsinitandrefresh; now stores locally the downloaded strings, that will be reused for the next app startuser_preferences_page_test.dart: refactored