wtf #20
Merged
wtf #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Code base cleanup
Deleted file: * `settings_page.dart`: all the code was moved to `user_preferences_page.dart` New files: * `abstract_user_preferences.dart`: Abstraction of a collapsed/expanded display for the preferences page. * `user_preferences_attribute_group.dart`: Collapsed/expanded display of one attribute group for the preferences page. * `user_preferences_food.dart`: Collapsed/expanded display of attribute groups for the preferences page. * `user_preferences_profile.dart`: Collapsed/expanded display of profile for the preferences page. * `user_preferences_settings.dart`: Collapsed/expanded display of settings for the preferences page. Impacted files: * `app_en.arb`: added 6 labels for preferences titles and subtitles * `app_fr.arb`: added 6 labels for preferences titles and subtitles * `labeler.yml`: removed reference to `settings_page.dart` * `user_preferences.dart`: added bool flags getter and setter * `user_preferences_page.dart`: now displays in accordion the same preferences, plus the former settings_page, plus the former action bar * `user_preferences_page-blue-dark.png` * `user_preferences_page-blue-light.png` * `user_preferences_page-brown-dark.png` * `user_preferences_page-brown-light.png` * `user_preferences_page-green-dark.png` * `user_preferences_page-green-light.png`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wtf