Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn the preferences tab into an accordeon #798

Closed
teolemon opened this issue Dec 29, 2021 · 1 comment
Closed

Turn the preferences tab into an accordeon #798

teolemon opened this issue Dec 29, 2021 · 1 comment
Assignees
@monsieurtanuki
Labels
food preferences
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Dec 29, 2021 •
edited
Loading

Why

  • Important call to actions are hidden 3 or 4 taps away, behind a cogwheel that's supposedly technical
  • We have a dedicated view for food preferences

What

  • Turn the preferences tab into an accordion per mocks
    • so that we can surface all the call to actions for the "Association" (eg Thank you, Donate, Translate, Contribute) in the collapsed first section (that will also be useful for login, and secondary features), instead of putting them in the cogwheel and top bar
  • Initially, only food preferences is expanded. The idea was to put a red badge on the other section to entice expansion.

Open Questions

  • Put everything at the same level, or introduce a second Contribute level ?

Mockup Basic concept

image

Mockup

  • I turned all links are turned into "Big Tapable Buttons™"

Profile (1)

Figma

https://www.figma.com/file/lhRhMulB4Ek9NYDWl3FxAo/Fellowship-Jam-file?node-id=1851%3A8187
@monsieurtanuki monsieurtanuki mentioned this issue Jan 1, 2022
Closed
1 task
@M123-dev M123-dev added this to the V 1 milestone Jan 1, 2022
@monsieurtanuki monsieurtanuki self-assigned this Jan 2, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 2, 2022
@monsieurtanuki
feat: openfoodfacts#798 - now a unique page for preferences, in accor…
24ef49b 
…dion

Deleted file:
* `settings_page.dart`: all the code was moved to `user_preferences_page.dart`

Impacted files:
* `labeler.yml`: removed reference to `settings_page.dart`
* `user_preferences.dart`: added bool flags getter and setter
* `user_preferences_page.dart`: now displays in accordion the same preferences, plus the former settings_page, plus the former action bar
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 2, 2022
@monsieurtanuki
feat: openfoodfacts#798 - simplification through abstraction
d2b6a86 
New files:
* `abstract_user_preferences.dart`: Abstraction of a collapsed/expanded display for the preferences page.
* `user_preferences_attribute_group.dart`: Collapsed/expanded display of attributes for the preferences page.
* `user_preferences_profile.dart`: Collapsed/expanded display of profile for the preferences page.
* `user_preferences_settings.dart`: Collapsed/expanded display of settings for the preferences page.

Impacted file:
* `user_preferences_page.dart`: huge simplification through the use of instances of new class `AbstractUserPreferences`
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 3, 2022
@monsieurtanuki
Merge branch 'monsieurtanuki-feature/openfoodfacts#798' into develop
ebcc532 
github merge rabbit hole
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 3, 2022
@monsieurtanuki
feat: openfoodfacts#798 - conflicts desperate fix around settings_pag…
b9a4ff1 
…e.dart
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 3, 2022
@monsieurtanuki
Merge branch 'develop' into feature/openfoodfacts#798
5761357
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 3, 2022
@monsieurtanuki
feat: openfoodfacts#798 - conflicts desperate fix around settings_pag…
bdf5557 
…e.dart

part 2/2
so far so good
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 3, 2022
@monsieurtanuki
Merge remote-tracking branch 'origin/feature/openfoodfacts#798' into …
0dac0b9 
…feature/openfoodfacts#798
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 3, 2022
@monsieurtanuki
feat: openfoodfacts#798 - localization and collapsable attribute groups
3808e55 
New file:
* `user_preferences_food.dart`: Collapsed/expanded display of attribute groups for the preferences page.

Impacted files:
* `abstract_user_preferences.dart`: refactored for localization
* `app_en.arb`: added 6 labels for preferences titles and subtitles
* `app_fr.arb`: added 6 labels for preferences titles and subtitles
* `user_preferences_attribute_group.dart`: now we manage here only one group at a time, to make it collapsable
* `user_preferences_page.dart`: refactored for localization
* `user_preferences_profile.dart`: refactored for localization
* `user_preferences_settings.dart`: refactored for localization
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 3, 2022
@monsieurtanuki
feat: openfoodfacts#798 - no cupertino allowed!
a6f8ee2 
Impacted file:
* `user_preferences_food.dart`
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 3, 2022
@monsieurtanuki
feat: openfoodfacts#798 - golden refresh
9d86aad 
Impacted files:
* `user_preferences_page-blue-dark.png`
* `user_preferences_page-blue-light.png`
* `user_preferences_page-brown-dark.png`
* `user_preferences_page-brown-light.png`
* `user_preferences_page-green-dark.png`
* `user_preferences_page-green-light.png`
monsieurtanuki added a commit that referenced this issue Jan 3, 2022
@monsieurtanuki
feat: #798 - now a unique page for preferences, in accordion (#820)
5ba0310 
Deleted file:
* `settings_page.dart`: all the code was moved to `user_preferences_page.dart`

New files:
* `abstract_user_preferences.dart`: Abstraction of a collapsed/expanded display for the preferences page.
* `user_preferences_attribute_group.dart`: Collapsed/expanded display of one attribute group for the preferences page.
* `user_preferences_food.dart`: Collapsed/expanded display of attribute groups for the preferences page.
* `user_preferences_profile.dart`: Collapsed/expanded display of profile for the preferences page.
* `user_preferences_settings.dart`: Collapsed/expanded display of settings for the preferences page.

Impacted files:
* `app_en.arb`: added 6 labels for preferences titles and subtitles
* `app_fr.arb`: added 6 labels for preferences titles and subtitles
* `labeler.yml`: removed reference to `settings_page.dart`
* `user_preferences.dart`: added bool flags getter and setter
* `user_preferences_page.dart`: now displays in accordion the same preferences, plus the former settings_page, plus the former action bar
* `user_preferences_page-blue-dark.png`
* `user_preferences_page-blue-light.png`
* `user_preferences_page-brown-dark.png`
* `user_preferences_page-brown-light.png`
* `user_preferences_page-green-dark.png`
* `user_preferences_page-green-light.png`
@monsieurtanuki
Copy link
Contributor

Done in #820.

@github-actions github-actions bot mentioned this issue Jan 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
food preferences
Projects
None yet
Milestone
V1
Development

No branches or pull requests
3 participants
@teolemon @monsieurtanuki @M123-dev