Code base cleanup

[M123-dev]

No description provided.

[M123-dev]

@teolemon this is one of two hardcoded app users, this even added two test (non food) products to the DB, when I remeber right we don't even need them anymore since we do not longer need a user to add a photo, right?

[teolemon]

• "we do not longer need a user to add a photo" ?
  • We have never formally needed a user for photos (it's attributed to openfoodfacts-contributors). I believe @stephanegigandet created a specific user to see how efficient Smoothie was at gathering photos.
• We still have the case where the user is not logged in, and where we could use that user

[monsieurtanuki]

Hi @M123-dev!
You can't have that many users:

const User myUser = User(userId: 'smoothie-app', password: 'strawberrybanana');

static const User SMOOTH_USER = User(
  userId: 'project-smoothie',
  password: 'smoothie',
  comment: 'Test user for project smoothie',
);

OpenFoodAPIConfiguration.globalUser ?? myUser
OpenFoodAPIConfiguration.globalUser ?? ProductQuery.SMOOTH_USER

My suggestions:

• remove one of the default users
• make the other one private, in ProductQuery
• add the following method in ProductQuery:

static User getUser() => OpenFoodAPIConfiguration.globalUser ?? _defaultUser;

• From now on use only ProductQuery.getUser()

Does that make sense?

[monsieurtanuki]

@M123-dev That's exactly what I had in mind, except for the name.
For consistency reasons with getLanguage and getCountry, getUser makes more sense, doesn't it?
If you have time, please consider either

• methods named getLanguage(), getCountry() and getUser()
• or getters named language, country and user