Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image not rendered in the alcohol panel #1013

Closed
teolemon opened this issue Jan 25, 2022 · 4 comments · Fixed by #1131
Closed

Image not rendered in the alcohol panel #1013

teolemon opened this issue Jan 25, 2022 · 4 comments · Fixed by #1131
Assignees
@monsieurtanuki
Labels
📖 Knowledge panels 🎯 P1

Comments

@teolemon
Copy link
Member

Image not rendered in the alcohol panel
Screenshot_20220125-210027.png
@jasmeet0817
Copy link
Contributor

what;s the barcode ?

@teolemon
Copy link
Member Author

I searched for champagne and took the first bottle I could find

@jasmeet0817
Copy link
Contributor

jasmeet0817 commented Jan 25, 2022 via email

@teolemon
Copy link
Member Author

image

@teolemon teolemon mentioned this issue Jan 27, 2022
Closed
@monsieurtanuki monsieurtanuki self-assigned this Feb 12, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Feb 12, 2022
@monsieurtanuki
fix: openfoodfacts#1013 - "knowledge images" can be displayed even wi…
cdd6223 
…th `null` with and height

Impacted file:
* `knowledge_panel_element_card.dart`: `null` width and height are tolerated
@monsieurtanuki monsieurtanuki linked a pull request Feb 12, 2022 that will close this issue
fix: #1013 - "knowledge images" don't crash anymore with null width and height #1131
Merged
monsieurtanuki added a commit that referenced this issue Feb 12, 2022
@monsieurtanuki
fix: #1013 - "knowledge images" can be displayed even with null wit…
4dcb9f5 
…h and height (#1131)

Impacted file:
* `knowledge_panel_element_card.dart`: `null` width and height are tolerated
Repository owner moved this from Todo to Done in 🤳🥫 The Open Food Facts mobile app (Android & iOS) Feb 12, 2022
@github-actions github-actions bot mentioned this issue Feb 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
📖 Knowledge panels 🎯 P1
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
3 participants
@teolemon @jasmeet0817 @monsieurtanuki