Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History tab should include scanned products #1048

Closed
jasmeet0817 opened this issue Jan 31, 2022 · 2 comments
Closed

History tab should include scanned products #1048

jasmeet0817 opened this issue Jan 31, 2022 · 2 comments
Assignees
@monsieurtanuki
Labels
history

Comments

@jasmeet0817
Copy link
Contributor

Currently the tab only shows products that were opened before, this can throw off users who consider "scanning" as part of their "history"
@jasmeet0817
Copy link
Contributor Author

@teolemon any comments?

@teolemon
Copy link
Member

Erm yes, it should include all scanned products, even if we don't open the full product page.

@monsieurtanuki monsieurtanuki self-assigned this Jan 31, 2022
monsieurtanuki added a commit to monsieurtanuki/smooth-app that referenced this issue Jan 31, 2022
@monsieurtanuki
fix: openfoodfacts#1048 - added the scanned product to history
03bd584 
Impacted file:
* `continuous_scan_model.dart`: added the scanned product to history
@github-actions github-actions bot mentioned this issue Jan 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
history
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@teolemon @jasmeet0817 @monsieurtanuki