Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no longer using deprecated API method getKnowledgePanels #1066

Merged

Conversation

monsieurtanuki
Copy link
Contributor

Impacted files:

  • knwoledge_panels_query.dart: no longer using deprecated API method getKnowledgePanels
  • pubspec.lock: impacted by pubpsec.yaml
  • pubspec.yaml: upgraded openfoodfacts

Impacted files:
* `knwoledge_panels_query.dart`: no longer using deprecated API method getKnowledgePanels
* `pubspec.lock`: impacted by `pubpsec.yaml`
* `pubspec.yaml`: upgraded `openfoodfacts`
@monsieurtanuki monsieurtanuki linked an issue Feb 3, 2022 that may be closed by this pull request
@M123-dev
Copy link
Member

M123-dev commented Feb 3, 2022

We can maybe talk about if it makes sense to query the panels together with the main product, because of data size but lets merge so that CI works again

cc @jasmeet0817

@monsieurtanuki monsieurtanuki merged commit 4dd0ab1 into openfoodfacts:develop Feb 3, 2022
@monsieurtanuki
Copy link
Contributor Author

We can maybe talk about if it makes sense to query the panels together with the main product, because of data size

Fair enough @M123-dev, and thank you for the review!

@jasmeet0817
Copy link
Contributor

We can maybe talk about if it makes sense to query the panels together with the main product, because of data size but lets merge so that CI works again

cc @jasmeet0817

Sorry for the late reply, was busy with the other job, yeah i agree, makes sense to just query once. In case we are worried about fetching too much data, we could query knowledge panels and product details separately but parallely, although I don't think we should worry about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getKnowledgePanels is deprecated
3 participants