-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: no longer using deprecated API method getKnowledgePanels #1066
fix: no longer using deprecated API method getKnowledgePanels #1066
Conversation
Impacted files: * `knwoledge_panels_query.dart`: no longer using deprecated API method getKnowledgePanels * `pubspec.lock`: impacted by `pubpsec.yaml` * `pubspec.yaml`: upgraded `openfoodfacts`
We can maybe talk about if it makes sense to query the panels together with the main product, because of data size but lets merge so that CI works again cc @jasmeet0817 |
Fair enough @M123-dev, and thank you for the review! |
Sorry for the late reply, was busy with the other job, yeah i agree, makes sense to just query once. In case we are worried about fetching too much data, we could query knowledge panels and product details separately but parallely, although I don't think we should worry about it. |
Impacted files:
knwoledge_panels_query.dart
: no longer using deprecated API method getKnowledgePanelspubspec.lock
: impacted bypubpsec.yaml
pubspec.yaml
: upgradedopenfoodfacts