-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a plan and designs for a user-friendly lists system #1073
Comments
@monsieurtanuki @stephanegigandet @g123k @M123-dev after several UX iterations, here's the plan for lists. |
@teolemon My main concern is that one: where do you go to the "All the Lists" page from? Other more minor comments:
|
Just out of curiosity and not to start a big discussion about if, if so probably better in a own dedicated issue but what db are we going for, back to a SQLLite solution or are we sticking with hive for the lists? |
@M123-dev There's no obvious reason to go back to SQFlite because of lists. Lists only contain barcodes. Products are bigger: if we had to move back to SQFlite it would probably be because of products. Unless users get very fond of lists. The reward for success! Let's stick to hive for the moment. |
+1 |
@M123-dev related to the Delete Button on History |
New file: * `product_list_user_dialog_helper.dart`: Dialog helper class for user product list. Impacted files: * `constant_icons.dart`: added method `getForwardIcon` * `dao_product_list.dart`: added methods related to user list management * `new_product_page.dart`: action bar with "add to list" button instead of just "edit product" button; added "lists" widget * `product_list.dart`: added `ProductListType.USER` as "End-user product list" * `product_list_page.dart`: added "clear" and "rename" popup options * `product_query_page_helper.dart`: impact of new `ProductListType.USER`
Impacted file: * `new_product_page.dart`
Impacted files: * `app_en.arb`: localizations in English * `app_fr.arb`: localizations in French * `edit_product_page.dart`: unrelated refactoring * `new_product_page.dart`: localizations * `product_list_page.dart`: localizations * `product_list_user_dialog_helper.dart`: localizations * `product_title_card.dart`: unrelated refactoring * `smooth_product_card_found.dart`: unrelated refactoring
* feat: #1073 - user-defined product lists New file: * `product_list_user_dialog_helper.dart`: Dialog helper class for user product list. Impacted files: * `constant_icons.dart`: added method `getForwardIcon` * `dao_product_list.dart`: added methods related to user list management * `new_product_page.dart`: action bar with "add to list" button instead of just "edit product" button; added "lists" widget * `product_list.dart`: added `ProductListType.USER` as "End-user product list" * `product_list_page.dart`: added "clear" and "rename" popup options * `product_query_page_helper.dart`: impact of new `ProductListType.USER` * feat: #1073 - lint check fix Impacted file: * `new_product_page.dart` * feat: #1073 - localizations and refactoring Impacted files: * `app_en.arb`: localizations in English * `app_fr.arb`: localizations in French * `edit_product_page.dart`: unrelated refactoring * `new_product_page.dart`: localizations * `product_list_page.dart`: localizations * `product_list_user_dialog_helper.dart`: localizations * `product_title_card.dart`: unrelated refactoring * `smooth_product_card_found.dart`: unrelated refactoring * Update packages/smooth_app/lib/l10n/app_en.arb * Update packages/smooth_app/lib/l10n/app_en.arb Co-authored-by: Pierre Slamich <pierre.slamich@gmail.com>
Impacted file: * `new_product_page.dart`: same title style as KP; no more confusing icon
@teolemon Still this question: from where should we get to the "list of existing lists" page? |
Fixed 👍 |
What
Part of
Early mockups for discussion
Mockups on Figma
The text was updated successfully, but these errors were encountered: